Skip to content

[SPARK-56455][SQL][TESTS] Add test for broadcast failure when exceeding maxBroadcastTableSize #55313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pratham76 wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −0
Open

[SPARK-56455][SQL][TESTS] Add test for broadcast failure when exceeding maxBroadcastTableSize #55313

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions sql/core/src/test/scala/org/apache/spark/sql/execution/BroadcastExchangeSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,17 @@ class BroadcastExchangeSuite extends SparkPlanTest
broadcastExchangeNode.resetMetrics()
assert(metrics("numOutputRows").value == 1)
}

test("SPARK-56455: broadcast should fail when table size exceeds maxBroadcastTableSize") {
withSQLConf(SQLConf.MAX_BROADCAST_TABLE_SIZE.key -> "100") {
Copy link
Copy Markdown
Member

@dongjoon-hyun dongjoon-hyun Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this negative case, yes. I agree that it seems that we didn't have explicitly before. Could you revise the PR title and test case name specifically for this because the current PR title, "Add test coverage for maxBroadcastTableSize config enforcement", is too broad and ignores the existing test coverage.

Copy link
Copy Markdown
Author

@pratham76 pratham76 Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted. Could i change the title as "Add test for broadcast failure when exceeding maxBroadcastTableSize"? This seems to be appropriate for the test coverage. Do let me know your thoughts. Thanks!

val df = spark.range(1000).toDF()
val joinDF = df.join(broadcast(df), "id")
val ex = intercept[SparkException] {
joinDF.collect()
}
assert(ex.getCondition == "_LEGACY_ERROR_TEMP_2249")
}
}
}

// Additional tests run in 'local-cluster' mode.
Expand Down