[SPARK-53848][SQL] Add ability to support Alpha family in Theta Aggregates#55300
Open
karuppayya wants to merge 2 commits intoapache:masterfrom
Open
[SPARK-53848][SQL] Add ability to support Alpha family in Theta Aggregates#55300karuppayya wants to merge 2 commits intoapache:masterfrom
karuppayya wants to merge 2 commits intoapache:masterfrom
Conversation
Contributor
Author
HyukjinKwon
changed the title
cboumalh
approved these changes
Apr 13, 2026
| // Constructors | ||
| private lazy val family: Family = { | ||
| if (!third.foldable) { | ||
| throw QueryExecutionErrors.thetaFamilyMustBeConstantError(prettyName) |
Contributor
There was a problem hiding this comment.
Ideally we can do this check at the analysis step in checkInputDataTypes to fail early, instead of at runtime. Same applies to the lgNomEntries. I can create a follow up, or we can make the modifications here if other reviewers see it fit.
Contributor
|
@karuppayya LGTM, thanks for the work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Adding ability to use ALPHA family for Theta Sketch
(Recreation of #52551 since it could not be re-opened)
Why are the changes needed?
Theta sketch aggregate currently supports only quick select.
Consumers like Iceberg will benefit from the sketch aggregate if has the ability to use
ALPHA familyIceberg specification to use ALPHA sketches
Custom implementation of theta sketch aggregates in Iceberg that can be replaced with Spark Theta aggregates
Does this PR introduce any user-facing change?
No
How was this patch tested?
Unit tests
Was this patch authored or co-authored using generative AI tooling?
No