Skip to content

[fix][test] fix testBatchMetadataStoreMetrics.#25241

Merged
BewareMyPower merged 1 commit intoapache:masterfrom
zhaizhibo:fix_testBatchMetadataStoreMetrics
Feb 12, 2026
Merged

[fix][test] fix testBatchMetadataStoreMetrics.#25241
BewareMyPower merged 1 commit intoapache:masterfrom
zhaizhibo:fix_testBatchMetadataStoreMetrics

Conversation

@zhaizhibo
Copy link
Contributor

Motivation

In PR #25187, the pulsar_batch_metadata_store_executor_queue_size metric was removed from BatchMetadataStoreStats. Therefore, related tests should also be updated to remove references to this metric.

Modifications

Removed the validation of the pulsar_batch_metadata_store_executor_queue_size metric in the testBatchMetadataStoreMetrics test.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Feb 12, 2026
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing!

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.66%. Comparing base (db91b93) to head (406786c).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #25241       +/-   ##
=============================================
+ Coverage     30.11%   72.66%   +42.55%     
- Complexity      109    34031    +33922     
=============================================
  Files          1899     1959       +60     
  Lines        151150   155406     +4256     
  Branches      17230    17726      +496     
=============================================
+ Hits          45513   112933    +67420     
+ Misses        98639    33473    -65166     
- Partials       6998     9000     +2002     
Flag Coverage Δ
inttests 25.75% <ø> (-0.03%) ⬇️
systests 22.37% <ø> (-0.05%) ⬇️
unittests 73.64% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1502 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@BewareMyPower
Copy link
Contributor

I'm wondering why CI passed?

@BewareMyPower
Copy link
Contributor

I see it's in the flaky test group, so it's ignored

@BewareMyPower BewareMyPower merged commit 9db31cc into apache:master Feb 12, 2026
102 of 105 checks passed
lhotari pushed a commit that referenced this pull request Feb 16, 2026
lhotari pushed a commit that referenced this pull request Feb 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants