[python] Data Evolution with_slice should use row id to do slice #7199
+113
−88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| first_row_id = entry.file.first_row_id | ||
| # Range is inclusive [from_, to], so use row_count - 1 | ||
| list_ranges.append(Range(first_row_id, first_row_id + entry.file.row_count - 1)) | ||
|
|
Contributor
There was a problem hiding this comment.
blob is included in the entry here.
Contributor
Author
There was a problem hiding this comment.
What does a blob have to do with it?
Contributor
There was a problem hiding this comment.
What does a blob have to do with it?
It should be ok, I misunderstood.
JingsongLi
force-pushed
the
data_evolution_with_slice
branch
from
a8948c0 to
542c44b
Compare
Contributor
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Only RowId can be trusted for Data Evolution table, otherwise, multiple versions of RowId files will result in data errors
Tests
API and Format
Documentation