[python/hotfix] fix bucket num calculation #7192
Merged
+130
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XiaoHongbo-Hope
changed the title
JingsongLi
reviewed
Feb 3, 2026
| return s | ||
|
|
||
|
|
||
| def _to_binary_row_bytes(type_names: List[str], values: Tuple[Any, ...]) -> bytes: |
Contributor
There was a problem hiding this comment.
Use GenericRowSerializer?
Contributor
Author
There was a problem hiding this comment.
Use
GenericRowSerializer?
Updated
| ] | ||
|
|
||
| @parameterized.expand([('parquet',), ('orc',), ('avro',)]) | ||
| def test_py_write_read_pk_table_bucket_num_calculate(self, file_format): |
Contributor
There was a problem hiding this comment.
Can you merge this method into test_py_write_read_pk_table?
Contributor
Author
There was a problem hiding this comment.
Can you merge this method into
test_py_write_read_pk_table?
Updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #xxx
Tests
API and Format
Documentation