HDDS-14646. SCM should not close Ratis pipelines on Finalize#9779
Open
sodonnel wants to merge 5 commits intoapache:HDDS-14496-zdufrom
Open
HDDS-14646. SCM should not close Ratis pipelines on Finalize#9779sodonnel wants to merge 5 commits intoapache:HDDS-14496-zdufrom
sodonnel wants to merge 5 commits intoapache:HDDS-14496-zdufrom
Conversation
github-actions
bot
added
the
zdu
added 4 commits
February 17, 2026 17:03
… all finalize before finalization is complete
sodonnel
force-pushed
the
close-pipelines
branch
from
c8172b8 to
fe8fff6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When SCM finalizes an upgrade, it should no longer close all the Ratis pipelines on the datanodes. Instead they should be kept open. The SCM finalize command now needs to wait for all healthy datanodes to report matching SLV and MLV versions to know they have been finalized. Only when all datanodes are finalized, should SCM complete the finalization process.
This change is mostly to remove the existing close pipeline code and anything else that depended on it. The only new code added is the change to wait in DNs reporting SVL == MVL, as before new pipelines being created was the trigger to complete the process.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14646
How was this patch tested?
Existing tests, some of which had to be adapted slightly.