HDDS-14629. Code cleanup after HDDS-13906#9773
Open
Russole wants to merge 2 commits intoapache:masterfrom
Open
HDDS-14629. Code cleanup after HDDS-13906#9773Russole wants to merge 2 commits intoapache:masterfrom
Russole wants to merge 2 commits intoapache:masterfrom
Conversation
yandrey321
reviewed
Feb 16, 2026
| path = getDbStore().getDbLocation().toPath().resolve(dbFile.getFileName()).toAbsolutePath().toString(); | ||
| } | ||
| omdbArchiver.getHardLinkFileMap().put(path, fileId); | ||
| String path = dbFile.toFile().getAbsolutePath(); |
Contributor
Author
There was a problem hiding this comment.
dbFile comes from either Files.list(...) or from a List<Path> created in extractSSTFilesFromCompactionLog().
From directory listing:
try (Stream<Path> files = Files.list(dbDir)) {
collectFilesFromDir(..., files, ...);
}From compaction log (in extractSSTFilesFromCompactionLog()):
sstFiles.add(sstBackupDir.resolve(f.getFileName() + ROCKSDB_SST_SUFFIX));In both cases, dbFile is a valid Path (no null elements). Also, Path.resolve() never returns null — it returns a Path or throws NullPointerException if the argument is null.
So dbFile.toFile().getAbsolutePath() cannot be null in this flow.
Contributor
Author
|
Thanks @yandrey321 for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
OMDBArchiverto own and initialize the hardlink mapping internally, removingsetHardLinkFileMap()and nullable state.relativize()inwriteHardlinkFileto prevent abs/relative path mismatch exceptions.recordHardLinkMapping()instead.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14629
How was this patch tested?