Harden RocksDB snapshot error handling.#9770
Open
vyalamar wants to merge 2 commits intoapache:masterfrom
Open
Conversation
vyalamar
changed the title
yandrey321
reviewed
Feb 15, 2026
| } catch (IOException | RocksDBException exception) { | ||
| // TODO: [SNAPSHOT] Fail gracefully. | ||
| throw new RuntimeException(exception); | ||
| throw SnapshotStorageException.fromRocksDB("append list entry", toRocks(exception)); |
There was a problem hiding this comment.
nit: 'append' -> 'Append' to be consistent with other messages.
yandrey321
reviewed
Feb 15, 2026
| } catch (IOException | RocksDBException exception) { | ||
| // TODO: [SNAPSHOT] Fail gracefully. | ||
| throw new RuntimeException(exception); | ||
| throw SnapshotStorageException.fromRocksDB("read list entry", toRocks(exception)); |
yandrey321
reviewed
Feb 15, 2026
| } catch (IOException exception) { | ||
| // TODO: [SNAPSHOT] Fail gracefully. | ||
| throw new RuntimeException(exception); | ||
| throw SnapshotStorageException.fromIO("deserialize list entry", exception); |
There was a problem hiding this comment.
nit: 'deserialize' -> 'Failed to deserialize'
yandrey321
reviewed
Feb 15, 2026
| } catch (IOException | RocksDBException exception) { | ||
| // TODO: [SNAPSHOT] Fail gracefully. | ||
| throw new RuntimeException(exception); | ||
| throw SnapshotStorageException.fromRocksDB("read map entry", toRocks(exception)); |
yandrey321
reviewed
Feb 15, 2026
| } catch (IOException | RocksDBException exception) { | ||
| // TODO: [SNAPSHOT] Fail gracefully. | ||
| throw new RuntimeException(exception); | ||
| throw SnapshotStorageException.fromRocksDB("write map entry", toRocks(exception)); |
yandrey321
reviewed
Feb 15, 2026
| } catch (IOException | RocksDBException exception) { | ||
| // TODO: [SNAPSHOT] Fail gracefully. | ||
| throw new RuntimeException(exception); | ||
| throw SnapshotStorageException.fromRocksDB("delete map entry", toRocks(exception)); |
There was a problem hiding this comment.
nit: 'delete' -> 'Failed to delete'
yandrey321
reviewed
Feb 15, 2026
| throw new RuntimeException(exception); | ||
| } | ||
| } catch (IOException exception) { | ||
| throw SnapshotStorageException.fromIO("deserialize map entry", exception); |
There was a problem hiding this comment.
'deserialize' -> 'Failed to deserialize'
yandrey321
reviewed
Feb 15, 2026
| }; | ||
| } | ||
|
|
||
| private RocksDBException toRocks(Exception e) { |
There was a problem hiding this comment.
code duplication, should be moved to the Utility class.
yandrey321
reviewed
Feb 15, 2026
| } catch (IOException | RocksDBException exception) { | ||
| // TODO: [SNAPSHOT] Fail gracefully. | ||
| throw new RuntimeException(exception); | ||
| throw SnapshotStorageException.fromRocksDB("add set entry", toRocks(exception)); |
yandrey321
reviewed
Feb 15, 2026
| } catch (IOException exception) { | ||
| // TODO: [SNAPSHOT] Fail gracefully. | ||
| throw new RuntimeException(exception); | ||
| throw SnapshotStorageException.fromIO("deserialize set entry", exception); |
There was a problem hiding this comment.
'deserialize' -> 'Failed to deserialize'
yandrey321
reviewed
Feb 15, 2026
| }; | ||
| } | ||
|
|
||
| private RocksDBException toRocks(Exception e) { |
There was a problem hiding this comment.
duplicated code, should be moved to the utility class
yandrey321
reviewed
Feb 15, 2026
|
|
||
| public static SnapshotStorageException fromRocksDB(String op, | ||
| RocksDBException e) { | ||
| return new SnapshotStorageException("Failed to " + op, |
There was a problem hiding this comment.
adding prefix to the message inside ctor would prevent developers from grepping the message in code.
yandrey321
reviewed
Feb 15, 2026
|
|
||
| public static SnapshotStorageException fromIO(String op, | ||
| java.io.IOException e) { | ||
| return new SnapshotStorageException("Failed to " + op, |
There was a problem hiding this comment.
adding prefix to the message inside ctor would prevent developers from grepping the message in code.
yandrey321
suggested changes
Feb 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing