HDDS-14590. Extract MultipartKeyHandler for MPU object operations#9768
Open
Russole wants to merge 5 commits intoapache:masterfrom
Open
HDDS-14590. Extract MultipartKeyHandler for MPU object operations#9768Russole wants to merge 5 commits intoapache:masterfrom
Russole wants to merge 5 commits intoapache:masterfrom
Conversation
adoroszlai
reviewed
Feb 16, 2026
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @Russole for the patch, mostly LGTM.
Comment on lines
102
to
110
| /** | ||
| * Abort multipart upload request. | ||
| * @param bucket | ||
| * @param key | ||
| * @param uploadId | ||
| * @return Response | ||
| * @throws IOException | ||
| * @throws OS3Exception | ||
| */ |
Contributor
There was a problem hiding this comment.
Let's remove this kind "junk" of javadoc:
- description is mandatory for
@paramand@throws, but missing @return Responsedoes not provide any additional information over return type in the method signature
| */ | ||
| private Response listParts(OzoneBucket ozoneBucket, String key, String uploadId, | ||
| int partNumberMarker, int maxParts, | ||
| org.apache.hadoop.ozone.audit.AuditLogger.PerformanceStringBuilder perf) |
Contributor
There was a problem hiding this comment.
Please add import for PerformanceStringBuilder.
|
|
||
| final int maxParts = queryParams().getInt(QueryParams.MAX_PARTS, 1000); | ||
| final String partNumberMarker = queryParams().get(QueryParams.PART_NUMBER_MARKER); | ||
| final long startNanos = context.getStartNanos(); |
Contributor
There was a problem hiding this comment.
Let's inline startNanos (call getStartNanos() when updating metrics).
| /** | ||
| * Handles MPU (Multipart Upload) non-POST operations for object key endpoint. | ||
| */ | ||
| public class MultipartKeyHandler extends ObjectOperationHandler { |
Contributor
There was a problem hiding this comment.
nit:
Suggested change
| public class MultipartKeyHandler extends ObjectOperationHandler { | |
| class MultipartKeyHandler extends ObjectOperationHandler { |
Contributor
Author
|
Thanks @adoroszlai for the review. |
Contributor
Thanks for updating the patch. Note that there is a checkstyle problem: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
ObjectOperationHandlersubclassMultipartKeyHandler.ObjectEndpoint'shandler chain before this.ObjectEndpointand implementObjectOperationHandlermethods using these methods.MultipartKeyHandler.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14590
How was this patch tested?