ORC-2069: Fix convert tool failed to read csv #2504
Closed
+6
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
approved these changes
Jan 30, 2026
| <groupId>org.apache.commons</groupId> | ||
| <artifactId>commons-lang3</artifactId> | ||
| <!-- convert tool CSVParser uses org.apache.commons.lang3 --> | ||
| <scope>runtime</scope> |
Member
There was a problem hiding this comment.
Just a question: Is runtime enough to build the uber jar to have this, @cxzl25 ?
Contributor
Author
There was a problem hiding this comment.
If it is declared as compile scope, the check of maven-dependency-plugin will report an error, so only runtime scope can be used.
[INFO] --- dependency:3.9.0:analyze-only (default) @ orc-tools ---
[ERROR] Unused declared dependencies found:
[ERROR] org.apache.commons:commons-lang3:jar:3.20.0:compile
Member
|
Merged to main/2.2. |
dongjoon-hyun
pushed a commit
that referenced
this pull request
Jan 30, 2026
### What changes were proposed in this pull request? This PR aims to fix convert tool failed to read csv. ### Why are the changes needed? `orc-tools-2.2.2-uber.jar` is not packaged `commons-lang3`, which causes its convert command to fail to read csv. ```java Exception in thread "main" java.lang.NoClassDefFoundError: org/apache/orc/shade/commons/lang3/ObjectUtils at com.opencsv.CSVParser.<init>(CSVParser.java:110) at com.opencsv.CSVParserBuilder.build(CSVParserBuilder.java:139) at org.apache.orc.tools.convert.CsvReader.<init>(CsvReader.java:89) at org.apache.orc.tools.convert.ConvertTool$FileInformation.getRecordReader(ConvertTool.java:162) at org.apache.orc.tools.convert.ConvertTool.run(ConvertTool.java:221) at org.apache.orc.tools.convert.ConvertTool.main(ConvertTool.java:174) at org.apache.orc.tools.Driver.main(Driver.java:118) Caused by: java.lang.ClassNotFoundException: org.apache.orc.shade.commons.lang3.ObjectUtils at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:580) at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:490) ... 7 more ``` ### How was this patch tested? local test ### Was this patch authored or co-authored using generative AI tooling? No Closes #2504 from cxzl25/ORC-2069. Authored-by: sychen <sychen@ctrip.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 7ecda8d) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to fix convert tool failed to read csv.
Why are the changes needed?
orc-tools-2.2.2-uber.jaris not packagedcommons-lang3, which causes its convert command to fail to read csv.How was this patch tested?
local test
Was this patch authored or co-authored using generative AI tooling?
No