website: apply theme variables and add toggle UI#158
Closed
siddhitripathi25 wants to merge 1 commit intoapache:masterfrom
Closed
website: apply theme variables and add toggle UI#158siddhitripathi25 wants to merge 1 commit intoapache:masterfrom
siddhitripathi25 wants to merge 1 commit intoapache:masterfrom
Conversation
- Update _sass/_base.scss to use CSS custom properties - Update _sass/_layout.scss to use theme variables - Apply consistent theming across site components This is step 3 of 3 for dark mode implementation.
d06bb48 to
5106bec
Compare
cederom
requested changes
Dec 8, 2025
Contributor
cederom
left a comment
There was a problem hiding this comment.
Thanks @siddhitripathi25 this change is already provided in PR #156 why creating in separate PR?
Contributor
|
Please provide functionality in a single PR as requested before. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@cederom 3rd part of pr of issue #148
Summary
Applies theme variables across the website and completes the dark mode implementation. This is the final step of the 3-part dark mode implementation.
Changes Made
_sass/_base.scssto use CSS custom properties_sass/_layout.scssto use theme variablesindex.mdhomepage for theme consistencyWhat This PR Does
var(--color-*)throughout site CSSImpact
Testing
Dependencies
Depends on:
Notes