website: add theme toggle components#157
Closed
siddhitripathi25 wants to merge 1 commit intoapache:masterfrom
Closed
website: add theme toggle components#157siddhitripathi25 wants to merge 1 commit intoapache:masterfrom
siddhitripathi25 wants to merge 1 commit intoapache:masterfrom
Conversation
aab5cb4 to
2468bc2
Compare
cederom
requested changes
Dec 8, 2025
Contributor
cederom
left a comment
There was a problem hiding this comment.
Thanks @siddhitripathi25 this change is already provided in PR #156 why creating separate PR?
Contributor
|
Please provide functionality in a single PR as requested before. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@cederom 2nd part of solving issue #148
Summary
Adds HTML components for theme switching functionality. This is the second step in implementing dark mode support for the NuttX website, providing the user interface elements needed for theme toggling.
Changes Made
_includes/theme-toggle.htmlwith accessible theme toggle buttonComponent Details
Theme Toggle Button Features:
aria-label="Toggle dark mode"for screen readerstheme-toggleclass for stylingImpact
Testing
Dependencies
Depends on: PR #XXX (
website: add CSS custom properties for theme support)Notes
Next Steps
The final PR will:
Related
Part of dark mode implementation to improve user experience, accessibility, and modern web standards compliance.