examples/fb: support for complete non-/consecutive fbdev mmap processing #3400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cederom
requested changes
Feb 4, 2026
Contributor
cederom
left a comment
cederom
left a comment
There was a problem hiding this comment.
Thank you @W-Mai :-)
- Please update PR description according to Contributing Guide (you can see that in the PR template).
- Please update git commit title
examples/fb: ... - Please remember to provide runtime logs.
- Build error.. a glitch?
Enhance fbdev mmap handling to support both consecutive and non-consecutive memory layouts. The implementation now correctly calculates memory offsets and performs mmap operations for the second framebuffer plane based on the physical memory addresses returned by the driver. Key changes: - Retrieve physical memory addresses for both display planes - Detect consecutive vs non-consecutive memory layouts - Calculate proper offset for mmap operations - Adjust framebuffer length based on memory layout - Improve error handling and resource cleanup Signed-off-by: xinbingnan <xinbingnan@xiaomi.com>
W-Mai
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Please adhere to Contributing Guidelines.
Summary
Enhance fbdev mmap handling to support both consecutive and
non-consecutive
memory layouts. The implementation now correctly calculates memory
offsets
and performs mmap operations for the second framebuffer plane based on
the
physical memory addresses returned by the driver.
Key changes:
Impact
N/A
Testing
N/A