Enable adding extra VM options for the NetBeans language server#21
Open
dasTanmoy0096 wants to merge 1 commit intoapache:masterfrom
Open
Enable adding extra VM options for the NetBeans language server#21dasTanmoy0096 wants to merge 1 commit intoapache:masterfrom
dasTanmoy0096 wants to merge 1 commit intoapache:masterfrom
Conversation
…ts from nbcode.conf The default VM options can conflict with environment variables such those a user may provide through JAVA_TOOL_OPTIONS. It's better if we don't provide any default options and let a user provide their own through this setting.
Author
|
@MartinBalin hello, can you please look into this? Thanks, |
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
Contributor
|
dasTanmoy0096 sorry, looking into it... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove bundled default -J heap/GC arguments from the launcher and add a new netbeans.serverVmOptions setting (array) so users can supply additional JVM arguments. The extension reads the setting and prepends each entry with -J when launching the language server; changes trigger a restart. This makes VM options configurable per-machine and avoids forcing defaults. Fixes issues such as:- #16
Click to collapse/expand PR instructions
By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
Please make sure (eg.
git log) that all commits have a valid name and email address for you in the Author field.If you're a first time contributor, see the Contributing guidelines for more information.
If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.
PR approval and merge checklist: