Skip to content

action-allowlist-review: bump manusa/actions-setup-minikube from 2.16.1 to 2.17.0 in /.github/actions/for-dependabot-triggered-reviews#848

Merged
potiuk merged 1 commit into
mainfrom
dependabot/github_actions/dot-github/actions/for-dependabot-triggered-reviews/manusa/actions-setup-minikube-2.17.0
May 18, 2026
Merged

action-allowlist-review: bump manusa/actions-setup-minikube from 2.16.1 to 2.17.0 in /.github/actions/for-dependabot-triggered-reviews#848
potiuk merged 1 commit into
mainfrom
dependabot/github_actions/dot-github/actions/for-dependabot-triggered-reviews/manusa/actions-setup-minikube-2.17.0

Conversation

@dependabot
Copy link
Copy Markdown
Contributor

@dependabot dependabot Bot commented on behalf of github May 17, 2026

Bumps manusa/actions-setup-minikube from 2.16.1 to 2.17.0.

Release notes

Sourced from manusa/actions-setup-minikube's releases.

v2.17.0

What's Changed

Full Changelog: manusa/actions-setup-minikube@v2.16.1...v2.17.0

Commits
  • 285c4cc [RELEASE] Release v2.17.0
  • d0f2bf9 chore(deps): bump @​actions/github from 6.0.0 to 8.0.1
  • a820593 chore(deps): bump axios from 1.13.6 to 1.16.1
  • f0ec2ac ci: extend arm64 matrix to addons, ingress, and containerd jobs
  • e441e61 chore(docs): document arm64 runner support
  • 2ade203 fix: support arm64 runners
  • cd375e9 test: extract createTarball helper to shared test-utils
  • 2fccca0 test(configure-environment): replace exec mock with stub scripts
  • 2281dbc test(configure-environment): replace core mock with stdout capture
  • 4ef4539 chore(docs): update README example to minikube v1.38.1 and K8s v1.35.2
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [manusa/actions-setup-minikube](https://github.com/manusa/actions-setup-minikube) from 2.16.1 to 2.17.0.
- [Release notes](https://github.com/manusa/actions-setup-minikube/releases)
- [Commits](manusa/actions-setup-minikube@96202de...285c4cc)

---
updated-dependencies:
- dependency-name: manusa/actions-setup-minikube
  dependency-version: 2.17.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels May 17, 2026
@dependabot dependabot Bot requested a review from dfoulks1 as a code owner May 17, 2026 13:17
@dependabot dependabot Bot added the dependencies Pull requests that update a dependency file label May 17, 2026
@dependabot dependabot Bot requested a review from potiuk as a code owner May 17, 2026 13:17
@dependabot dependabot Bot added the github_actions Pull requests that update GitHub Actions code label May 17, 2026
@dependabot dependabot Bot requested a review from ppkarwasz as a code owner May 17, 2026 13:17
@potiuk
Copy link
Copy Markdown
Member

potiuk commented May 17, 2026

Reviewed v2.17.0 in detail. Recommending approval.

Provenance: SHA matches tag v2.17.0; commit GPG-signed by maintainer @manusa (Marc Nuri).

What changed v2.16.1 → v2.17.0:

  • fix: support arm64 runners (fix: support arm64 runners manusa/actions-setup-minikube#148) — new src/arch.js, platform detection in src/download.js.
  • refactor(github): make API base URLs configurable via environment — reads GITHUB_API_URL / GITHUB_SERVER_URL (GHES compat).
  • refactor: use node: prefix for built-in module imports.
  • chore(deps): bump axios 1.13.6 → 1.16.1 and @actions/github 6 → 8.
  • Test refactoring. action.yml is byte-identical to v2.16.1.

VAB output is ✗ on 3 checks, but every finding is inherited from approved v2.16.1:

Finding Status
node_modules/@actions/tool-cache/scripts/externals/7zdec.exe — no SLSA / SHA256SUMS Byte-identical to v2.16.1 (same blob SHA, 42496 bytes). Owned by actions/toolkit, not by manusa.
src/github.js:13axios({method:'GET', ...}) flagged as "unverified download" False positive — this is a JSON API call to fetch release metadata, not a binary download. Tracked separately.
src/download.js:37, src/download.js:114tc.downloadTool() without post-download checksum Pre-existing code paths; same shape in v2.16.1. The action explicitly excludes signature files (isSignature filter) so checksums are available upstream but not consumed. Worth a follow-up issue to manusa, but not new in this bump.
JS rebuild "DIFFERENCES DETECTED" Only 3 files differ and all are metadata (axios/CHANGELOG.md, semver/package.json, tunnel/package.json) — transitive-dep version drift between maintainer's install and our rebuild. No runtime code differences.

3 ASF projects depend on this action (trafficserver-ingress-controller, pekko-samples, pekko-management).

@potiuk
Copy link
Copy Markdown
Member

potiuk commented May 17, 2026

I think It should be OK to approve - opened PR in our repo (to fix the false-positive) and opened PR in the action to not skip SHA verification.

@potiuk
Copy link
Copy Markdown
Member

potiuk commented May 17, 2026

WDYT?

Copy link
Copy Markdown
Member

@ppkarwasz ppkarwasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

potiuk added a commit to kevingurney/infrastructure-actions that referenced this pull request May 18, 2026
…fetch

manusa/actions-setup-minikube@v2.17.0 has a thin axios wrapper in
src/github.js that fetches GitHub release metadata as JSON:

  return axios({method: 'GET', ...options, url, headers});

The file is a transport-layer helper — no data-parse markers, no
binary-handling markers — so `_file_is_pure_data_fetch` didn't
exempt it and the axios call landed in the unverified-download list.

Authorization headers with `token ` or `Bearer ` prefixes are an
unambiguous "authenticated API call" signal: public release-asset
downloads from S3 / CDN / GitHub Releases don't use bearer auth.
Add that as a data-parse marker so transport-layer API helpers stop
producing false positives.  Real binary handlers in the same file
still trip `_JS_BINARY_HANDLE_PATTERNS` and override the exemption.

Surfaced while triaging apache#848.

Generated-by: Claude Opus 4.7 (1M context)
@potiuk potiuk merged commit d7ee322 into main May 18, 2026
9 of 10 checks passed
@potiuk potiuk deleted the dependabot/github_actions/dot-github/actions/for-dependabot-triggered-reviews/manusa/actions-setup-minikube-2.17.0 branch May 18, 2026 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants