Conversation
Bumps [manusa/actions-setup-minikube](https://github.com/manusa/actions-setup-minikube) from 2.16.1 to 2.17.0. - [Release notes](https://github.com/manusa/actions-setup-minikube/releases) - [Commits](manusa/actions-setup-minikube@96202de...285c4cc) --- updated-dependencies: - dependency-name: manusa/actions-setup-minikube dependency-version: 2.17.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Member
|
Reviewed v2.17.0 in detail. Recommending approval. Provenance: SHA matches tag What changed v2.16.1 → v2.17.0:
VAB output is ✗ on 3 checks, but every finding is inherited from approved v2.16.1:
3 ASF projects depend on this action (trafficserver-ingress-controller, pekko-samples, pekko-management). |
Member
|
I think It should be OK to approve - opened PR in our repo (to fix the false-positive) and opened PR in the action to not skip SHA verification. |
Member
|
WDYT? |
potiuk
added a commit
to kevingurney/infrastructure-actions
that referenced
this pull request
May 18, 2026
…fetch
manusa/actions-setup-minikube@v2.17.0 has a thin axios wrapper in
src/github.js that fetches GitHub release metadata as JSON:
return axios({method: 'GET', ...options, url, headers});
The file is a transport-layer helper — no data-parse markers, no
binary-handling markers — so `_file_is_pure_data_fetch` didn't
exempt it and the axios call landed in the unverified-download list.
Authorization headers with `token ` or `Bearer ` prefixes are an
unambiguous "authenticated API call" signal: public release-asset
downloads from S3 / CDN / GitHub Releases don't use bearer auth.
Add that as a data-parse marker so transport-layer API helpers stop
producing false positives. Real binary handlers in the same file
still trip `_JS_BINARY_HANDLE_PATTERNS` and override the exemption.
Surfaced while triaging apache#848.
Generated-by: Claude Opus 4.7 (1M context)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps manusa/actions-setup-minikube from 2.16.1 to 2.17.0.
Release notes
Sourced from manusa/actions-setup-minikube's releases.
Commits
285c4cc[RELEASE] Release v2.17.0d0f2bf9chore(deps): bump@actions/githubfrom 6.0.0 to 8.0.1a820593chore(deps): bump axios from 1.13.6 to 1.16.1f0ec2acci: extend arm64 matrix to addons, ingress, and containerd jobse441e61chore(docs): document arm64 runner support2ade203fix: support arm64 runnerscd375e9test: extract createTarball helper to shared test-utils2fccca0test(configure-environment): replace exec mock with stub scripts2281dbctest(configure-environment): replace core mock with stdout capture4ef4539chore(docs): update README example to minikube v1.38.1 and K8s v1.35.2Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)