fix(ci): prevent flaky keyring tests by deferring unlock to test phase#2995
Open
fix(ci): prevent flaky keyring tests by deferring unlock to test phase#2995
Conversation
gnome-keyring collection auto-locks after idle timeout. Unlocking before `cargo build` left a 7+ minute idle window (build + compile) before tests ran, causing org.freedesktop.Secret.Error.IsLocked ~10% of CI runs. Move D-Bus and keyring setup to right before test execution in both pre-merge and post-merge workflows.
numinnex
approved these changes
Mar 20, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2995 +/- ##
============================================
- Coverage 71.81% 71.80% -0.02%
Complexity 930 930
============================================
Files 1116 1116
Lines 92616 92616
Branches 70139 70149 +10
============================================
- Hits 66512 66499 -13
- Misses 23543 23548 +5
- Partials 2561 2569 +8
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
spetz
approved these changes
Mar 20, 2026
mmodzelewski
approved these changes
Mar 20, 2026
krishvishal
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gnome-keyring collection auto-locks after idle timeout.
Unlocking before
cargo buildleft a 7+ minute idlewindow (build + compile) before tests ran, causing
org.freedesktop.Secret.Error.IsLocked ~10% of CI runs.
Move D-Bus and keyring setup to right before test
execution in both pre-merge and post-merge workflows.