Open-API: Replace shadow JAR with distribution plugin for REST fixture#16214
Open
kevinjqliu wants to merge 16 commits intoapache:mainfrom
Open
Open-API: Replace shadow JAR with distribution plugin for REST fixture#16214kevinjqliu wants to merge 16 commits intoapache:mainfrom
kevinjqliu wants to merge 16 commits intoapache:mainfrom
Conversation
Co-authored-by: Copilot <copilot@github.com>
9261ef1 to
f2ee703
Compare
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Contributor
Author
|
this is ready for first round of review. Please take a look at once those are good, please check |
Member
|
I'm wondering whether we need all those jars and bundles for docker image and integration tests in iceberg-python and iceberg-rust. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
distributionplugin, modelled afterkafka-connect-runtime. Uses
installDist/distZipinstead ofshadowJar,producing a
lib/directory of individual JARs (66 JARs, 59MB total vs 201MBshadow JAR).
iceberg-bigquery) and JUnit from the distribution. Cloud bundles are copied as
separate shadow JARs in the Dockerfile.
java -cp "lib/*"with theinstallDistoutputinstead of
java -jarwith the shadow JAR. RemoveEXPOSEsince it isbuild-time metadata that cannot track runtime port overrides.
REST_PORTenv var — renamed toCATALOG_REST_PORTso the server readsit through the
CATALOG_*environment mapping convention.installDistplus cloud bundleshadowJartasks.Motivation
The shadow JAR bundled all transitive dependencies into a single 201MB JAR that was
unintentionally published to Maven Central.
Replacing it with individual JARs in a
lib/directory:META-INF/LICENSETesting
./gradlew :iceberg-open-api:installDistproduces 66 JARs (no JUnit, no cloud thin modules)./gradlew :iceberg-open-api:checkRuntimeDepspasses against baselinejava -cp "lib/*" org.apache.iceberg.rest.RESTCatalogServerstarts,/v1/configand/v1/namespacesrespond correctly