HBASE-30020 Introduce cache placement and admission policy API#8184
Open
VladRodionov wants to merge 1 commit intoapache:HBASE-30018from
Open
HBASE-30020 Introduce cache placement and admission policy API#8184VladRodionov wants to merge 1 commit intoapache:HBASE-30018from
VladRodionov wants to merge 1 commit intoapache:HBASE-30018from
Conversation
petersomogyi
approved these changes
May 5, 2026
Contributor
petersomogyi
left a comment
petersomogyi
left a comment
There was a problem hiding this comment.
LGTM. Clean API design with good Javadocs.
Comment on lines
+50
to
+54
| public static RepresentationDecision of(RepresentationKind kind) { | ||
| return kind == RepresentationKind.CURRENT_HBASE_DEFAULT | ||
| ? CURRENT_HBASE_DEFAULT | ||
| : new RepresentationDecision(kind); | ||
| } |
Contributor
There was a problem hiding this comment.
I'm not sure if this will be on a hot path but if so then you can cache all 4 RepresentationKind instances since the enum is small and fixed.
Contributor
There was a problem hiding this comment.
This class seems redundant with RepresentationKind, is it planned to implement any additional logic in the future? Otherwise, can these two just be merged?
Contributor
Author
There was a problem hiding this comment.
Yep, looks over engineered. Will remove it.
wchevreuil
reviewed
May 5, 2026
Comment on lines
+50
to
+54
| public static RepresentationDecision of(RepresentationKind kind) { | ||
| return kind == RepresentationKind.CURRENT_HBASE_DEFAULT | ||
| ? CURRENT_HBASE_DEFAULT | ||
| : new RepresentationDecision(kind); | ||
| } |
Contributor
There was a problem hiding this comment.
This class seems redundant with RepresentationKind, is it planned to implement any additional logic in the future? Otherwise, can these two just be merged?
VladRodionov
force-pushed
the
HBASE-30020-placement-admission-policy
branch
from
6a3b1be to
57513fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR targets the HBASE-30018 feature branch.
Introduces the cache placement/admission policy layer for the pluggable block cache architecture.
Adds:
The default policy preserves current HBase behavior:
No read/write path migration is included in this PR.
No behavior change intended.
JIRA: HBASE-30020