HBASE-30117 Fix HBase shell CONFIGURATION for column family using setValue instead of setConfiguration#8144
Open
jinhyukify wants to merge 4 commits intoapache:masterfrom
Open
HBASE-30117 Fix HBase shell CONFIGURATION for column family using setValue instead of setConfiguration#8144jinhyukify wants to merge 4 commits intoapache:masterfrom
jinhyukify wants to merge 4 commits intoapache:masterfrom
Conversation
…Value instead of setConfiguration
Member
|
It seems no one has a clear answer, but I got the impression that "configuration" was being phased out in favor of "value". So previously in #6986, I updated the checker to check both maps, instead of reverting what we already changed in HBASE-20819. Can we do the same here, instead of reviving the use of the configuration map? |
…sing setValue instead of setConfiguration" This reverts commit 16aaa48.
…loom filter configuration set via setValue
Contributor
Author
|
@junegunn Thank you for your review.
|
jinhyukify
commented
May 4, 2026
Comment on lines
+236
to
+237
| Configuration cfdConf = new CompoundConfiguration().add(conf) | ||
| .addStringMap(cfd.getConfiguration()).addBytesMap(cfd.getValues()); |
Contributor
Author
There was a problem hiding this comment.
This will fix this bug:
Before
# This should fail but succeed
create 'mytable2', {NAME => 'f', CONFIGURATION => {'hbase.hstore.datatiering.type' => 'TIME_RANGE', 'hbase.hstore.engine.class' => 'org.apache.hadoop.hbase.regionserver.DefaultStoreEngine'}}
After
# This fails
create 'mytable2', {NAME => 'f', CONFIGURATION => {'hbase.hstore.datatiering.type' => 'TIME_RANGE', 'hbase.hstore.engine.class' => 'org.apache.hadoop.hbase.regionserver.DefaultStoreEngine'}}
ERROR: org.apache.hadoop.hbase.DoNotRetryIOException: Time Range Data Tiering should be enabled with Date Tiered Compaction. Set hbase.table.sanity.checks to false at conf or table descriptor if you want to bypass sanity checks
at org.apache.hadoop.hbase.util.TableDescriptorChecker.warnOrThrowExceptionForFailure(TableDescriptorChecker.java:365)
at org.apache.hadoop.hbase.util.TableDescriptorChecker.warnOrThrowExceptionForFailure(TableDescriptorChecker.java:382)
at org.apache.hadoop.hbase.util.TableDescriptorChecker.checkDateTieredCompactionForTimeRangeDataTiering(TableDescriptorChecker.java:247)
at org.apache.hadoop.hbase.util.TableDescriptorChecker.checkDateTieredCompactionForTimeRangeDataTiering(TableDescriptorChecker.java:238)
at org.apache.hadoop.hbase.util.TableDescriptorChecker.sanityCheck(TableDescriptorChecker.java:210)
at org.apache.hadoop.hbase.master.HMaster.createTable(HMaster.java:2494)
at org.apache.hadoop.hbase.master.MasterRpcServices.createTable(MasterRpcServices.java:792)
at org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java)
at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:461)
at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:124)
at org.apache.hadoop.hbase.ipc.RpcHandler.run(RpcHandler.java:102)
at org.apache.hadoop.hbase.ipc.RpcHandler.run(RpcHandler.java:82)
Caused by: java.lang.IllegalArgumentException: Time Range Data Tiering should be enabled with Date Tiered Compaction.
at org.apache.hadoop.hbase.util.TableDescriptorChecker.lambda$checkDateTieredCompactionForTimeRangeDataTiering$4(TableDescriptorChecker.java:253)
at org.apache.hadoop.hbase.util.TableDescriptorChecker.warnOrThrowExceptionForFailure(TableDescriptorChecker.java:380)
... 10 more
junegunn
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira https://issues.apache.org/jira/browse/HBASE-30117