Skip to content

Conversation

@apurtell
Copy link
Contributor

No description provided.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 11s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for branch
_ Patch Compile Tests _
+0 🆗 mvndep 0m 3s Maven dependency ordering for patch
_ Other Tests _
1m 11s
Subsystem Report/Notes
Docker ClientAPI=1.53 ServerAPI=1.53 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7680/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #7680
Optional Tests
uname Linux bea74100bcf5 6.14.0-1018-aws #18~24.04.1-Ubuntu SMP Mon Nov 24 19:46:27 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 566b393
Max. process+thread count 38 (vs. ulimit of 30000)
modules C: U:
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7680/1/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 31s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 shelldocs 0m 1s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for branch
+1 💚 spotless 0m 46s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 4s Maven dependency ordering for patch
+1 💚 blanks 0m 0s The patch has no blanks issues.
-1 ❌ hadolint 0m 0s /results-hadolint.txt The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
-0 ⚠️ shellcheck 0m 2s /results-shellcheck.txt The patch generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2)
+1 💚 spotless 0m 41s patch has no errors when running spotless:check.
_ Other Tests _
+0 🆗 asflicense 0m 0s ASF License check generated no output?
3m 21s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7680/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #7680
Optional Tests dupname asflicense codespell detsecrets shellcheck shelldocs spotless hadolint
uname Linux 78f7b21c7357 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 566b393
Max. process+thread count 48 (vs. ulimit of 30000)
modules C: U:
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7680/1/console
versions git=2.34.1 maven=3.9.8 hadolint=2.10.0 shellcheck=0.8.0
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

&& apt-get clean \
&& rm -rf /var/lib/apt/lists/* \
&& update-alternatives --set java /usr/lib/jvm/java-8-openjdk-amd64/jre/bin/java \
&& update-alternatives --set java /usr/lib/jvm/java-8-openjdk-`uname -m | sed -e s/aarch64/arm64/ | sed -e s/x86_64/amd64/`/jre/bin/java \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we simplify the architecture mapping and add a safety check for the Java path? Splitting this into two steps makes it more readable and prevents the script from failing silently if the directory is missing.
e.g. something like below.
arch=$(uname -m | sed -e 's/aarch64/arm64/' -e 's/x86_64/amd64/')
java_bin="/usr/lib/jvm/java-8-openjdk-${arch}/jre/bin/java"

Also, we should add a check (or at least a comment) to verify that the path /usr/lib/jvm/java-8-openjdk-${arch}/... exists, as we're currently assuming it’s always present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants