-
Notifications
You must be signed in to change notification settings - Fork 3.4k
HBASE-29849 create-release do-release-docker.sh only works for x86_64 #7680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
| && apt-get clean \ | ||
| && rm -rf /var/lib/apt/lists/* \ | ||
| && update-alternatives --set java /usr/lib/jvm/java-8-openjdk-amd64/jre/bin/java \ | ||
| && update-alternatives --set java /usr/lib/jvm/java-8-openjdk-`uname -m | sed -e s/aarch64/arm64/ | sed -e s/x86_64/amd64/`/jre/bin/java \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we simplify the architecture mapping and add a safety check for the Java path? Splitting this into two steps makes it more readable and prevents the script from failing silently if the directory is missing.
e.g. something like below.
arch=$(uname -m | sed -e 's/aarch64/arm64/' -e 's/x86_64/amd64/')
java_bin="/usr/lib/jvm/java-8-openjdk-${arch}/jre/bin/java"
Also, we should add a check (or at least a comment) to verify that the path /usr/lib/jvm/java-8-openjdk-${arch}/... exists, as we're currently assuming it’s always present.
No description provided.