[VL] Gluten-it: Rename column c_last_review_date to c_last_review_date_sk#11792
Open
zhztheplayer wants to merge 2 commits intoapache:mainfrom
Open
[VL] Gluten-it: Rename column c_last_review_date to c_last_review_date_sk#11792zhztheplayer wants to merge 2 commits intoapache:mainfrom
c_last_review_date to c_last_review_date_sk#11792zhztheplayer wants to merge 2 commits intoapache:mainfrom
Conversation
|
Run Gluten Clickhouse CI on x86 |
1 similar comment
|
Run Gluten Clickhouse CI on x86 |
To comply with TPC-DS v2.7's schema specification: https://www.tpc.org/tpc_documents_current_versions/pdf/tpc-ds_v2.7.0.pdf
zhztheplayer
force-pushed
the
wip-it-last-review-col-name
branch
from
67ffd0f to
35f00a9
Compare
|
Run Gluten Clickhouse CI on x86 |
zhouyuan
reviewed
Mar 20, 2026
| StructField("c_login", StringType), | ||
| StructField("c_email_address", StringType), | ||
| StructField("c_last_review_date", StringType) | ||
| StructField("c_last_review_date_sk", StringType) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To comply with TPC-DS v2.7's schema specification:
https://www.tpc.org/tpc_documents_current_versions/pdf/tpc-ds_v2.7.0.pdf
The wrong name is causing inconsistency in some internal tests on Q30.
It's needed to add
--data-gen=alwaysthe first time when a test is executed to regenerate the tables within new schema after this change.