[hotfix][test] Move some auto-closable variables into try-block to manage the closing of objects for MassiveStringSorting.java

[RocMarshal]

What is the purpose of the change

• [hotfix][test] Use Long#compare to replace equivalent statements to improve readability.
• [hotfix][test] Move some auto-closable variables into try-block to manage the closing of objects for MassiveStringSorting.java

Brief change log

• [hotfix][test] Use Long#compare to replace equivalent statements to improve readability.
• [hotfix][test] Move some auto-closable variables into try-block to manage the closing of objects for MassiveStringSorting.java

Verifying this change

This change is a trivial rework / code cleanup

Does this pull request potentially affect one of the following parts:

• Dependencies (does it add or upgrade a dependency): (yes / no)
• The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
• The serializers: (yes / no / don't know)
• The runtime per-record code paths (performance sensitive): (yes / no / don't know)
• Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
• The S3 file system connector: (yes / no / don't know)

Documentation

• Does this pull request introduce a new feature? (yes / no)
• If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

[flinkbot]

CI report:

• 135b2ad Azure: SUCCESS

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot run azure re-run the last Azure build

[spuru9]

Though not related to the file but it would be nice to have this change in

flink/flink-tests/src/test/java/org/apache/flink/test/manual/MassiveStringValueSorting.java

Line 392 in 106acbc

BufferedWriter wrt = null;

and

flink/flink-tests/src/test/java/org/apache/flink/test/manual/MassiveStringValueSorting.java

Line 424 in 106acbc

BufferedWriter wrt = null;

as well

[RocMarshal]

Thanks @spuru9 .
Nice catch!
Updated

[spuru9]

Thanks for the change.
LGTM +1

[RocMarshal]

Thanks @spuru9 @mateczagany .
Merging...