Open
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements a feature to hide Excel columns using the @HeadStyle(hidden = BooleanEnum.TRUE) annotation, addressing issue #116.
- Adds a new
HiddenShellWriteHandlerto process column hiding based on annotation configuration - Integrates the handler into the existing write handler chain
- Adds documentation for the existing
hidden()method inHeadStyleannotation
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| AbstractWriteHolder.java | Registers the new HiddenShellWriteHandler in the write handler chain |
| HiddenShellWriteHandler.java | New handler that processes @HeadStyle(hidden=true) annotations to hide Excel columns |
| HeadStyle.java | Adds documentation referencing the new handler implementation |
| HiddenShellTest.java | Test case demonstrating the column hiding functionality |
Comments suppressed due to low confidence (2)
fastexcel/src/main/java/cn/idev/excel/write/handler/impl/HiddenShellWriteHandler.java:18
- The class name 'HiddenShellWriteHandler' is misleading since it hides columns, not shells. Consider renaming to 'HiddenColumnWriteHandler' for clarity.
public class HiddenShellWriteHandler implements SheetWriteHandler {
fastexcel-test/src/test/java/cn/idev/excel/test/fix/issue116/HiddenShellTest.java:15
- The test class name 'HiddenShellTest' should be 'HiddenColumnTest' to accurately reflect that it tests column hiding functionality.
public class HiddenShellTest {
fastexcel/src/main/java/cn/idev/excel/write/handler/impl/HiddenShellWriteHandler.java
Outdated
Show resolved
Hide resolved
fastexcel/src/main/java/cn/idev/excel/annotation/write/style/HeadStyle.java
Show resolved
Hide resolved
…nShellWriteHandler.java good Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
alaahong
reviewed
Aug 3, 2025
Member
alaahong
left a comment
alaahong
left a comment
There was a problem hiding this comment.
You should assert/verify in unittest
| */ | ||
| public class HiddenShellTest { | ||
|
|
||
| public static void main(String[] args) { |
Member
There was a problem hiding this comment.
please write unit test than main for verification
| DemoModel exportModel = new DemoModel(category, i, "test" + i); | ||
| dataList.add(exportModel); | ||
| } | ||
| return dataList; |
Member
There was a problem hiding this comment.
Can you try to write a real unit test? not just perform the method
psxjoy
requested changes
Aug 7, 2025
| import cn.idev.excel.write.handler.impl.HiddenRowWriteHandler; | ||
| import java.util.ArrayList; | ||
| import java.util.List; | ||
| import lombok.*; |
| import org.junit.jupiter.api.Test; | ||
|
|
||
| /** | ||
| * @author zz_zhi |
Author
|
Are there any other problems? |
Member
|
still some files are conflicted with main branch
zz-zhi ***@***.***>于2025年11月14日 周五18:24写道：
… *zz-zhi54* left a comment (apache/fesod#457)
<#457 (comment)>
Are there any other problems?
—
Reply to this email directly, view it on GitHub
<#457 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACRXFDSB7WRS6IIVB7RBBQT34WUUTAVCNFSM6AAAAACCZDOEXOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTKMZSGAZTKMZSHA>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
#116
What's changed?
Checklist