feat: implement isReady and setOnReadyHandler for Triple protocol #15827 #15959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@zrlw this was the one I was currently working on , giving me headache |
Contributor
you should run all testcases of the project successfully before submit a pr. |
Author
|
Author
|
@zrlw because it is closed , now I should stop working on it |
Contributor
This is not a place for personal code testing. |
Author
|
@zrlw okay will improve on that, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15827.
Implemented backpressure support by adding isReady() and setOnReadyHandler() to the Triple protocol stream observers and wiring them to the Netty channel writability events.