Skip to content

fix(golang): update metrics doc to latest version#3192

Open
Alanxtl wants to merge 1 commit intoapache:masterfrom
Alanxtl:fix_metrics
Open

fix(golang): update metrics doc to latest version#3192
Alanxtl wants to merge 1 commit intoapache:masterfrom
Alanxtl:fix_metrics

Conversation

@Alanxtl
Copy link
Copy Markdown
Contributor

@Alanxtl Alanxtl commented Feb 13, 2026

No description provided.

@netlify
Copy link
Copy Markdown

netlify bot commented Feb 13, 2026

Deploy Preview for dubbo ready!

Name Link
🔨 Latest commit 8135637
🔍 Latest deploy log https://app.netlify.com/projects/dubbo/deploys/698f211cd85e84000878447f
😎 Deploy Preview https://deploy-preview-3192--dubbo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 25 (🔴 down 9 from production)
Accessibility: 84 (no change from production)
Best Practices: 83 (🔴 down 9 from production)
SEO: 85 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

AlexStocks

This comment was marked as outdated.

Copy link
Copy Markdown
Contributor

@AlexStocks AlexStocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

文档更新内容较多,整体结构更清晰了。发现几个问题:

1. 标题格式混乱:

  • 英文章节用「# 1.」「## 1️⃣」混用 emoji
  • 中文章节用「# 一、」「## 1️⃣」混用数字和 emoji

2. app_port 描述模糊:
Pull 模式部分写的是 http://localhost:<app_port>/prometheus,但没说明这个端口是什么(Provider 还是 Consumer 端口?默认是多少?)

3. grafana.json 来源不明:
Step 4.2 说"Upload grafana.json",但这个文件在哪里?示例仓库里有吗?需要给出具体路径或下载链接。

4. RBAC 配置缺失:
旧版本有完整的 Role/RoleBinding 配置,新版本删掉了。如果集群启用了 RBAC,Prometheus 无法访问 Pod 指标,建议保留 RBAC 配置作为可选步骤。

5. tools/pgw-cleaner 位置不明:
文中提到这个工具用于清理僵尸指标,但在哪个仓库?dubbo-go 还是独立项目?需要说明清楚。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants