Add mockito to dependencyManagement

[raboof]

So we only need to maintain the version to be the latest that supports Java 8 here.

See also apache/commons-bcel#400

Thanks for your contribution to Apache Commons! Your help is appreciated!

Before you push a pull request, review this list:

• Read the contribution guidelines for this project.
• Run a successful build using the default Maven goal with mvn; that's mvn on the command line by itself.
• Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible but is a best-practice.
• Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
• Each commit in the pull request should have a meaningful subject line and body. Note that commits might be squashed by a maintainer on merge.

[garydgregory]

Note that I had to revert the Dependabot change because GitHub failed running the file. Also keep in mind that not all Commons components are stuck on Java 8 so doing this check would be counterproductive for Commons DbUtils for example. Gary

…

On Thu, Jan 2, 2025, 04:03 Arnout Engelen ***@***.***> wrote: So we only need to maintain the version to be the latest that supports Java 8 here. See also apache/commons-bcel#400 <apache/commons-bcel#400> Thanks for your contribution to Apache Commons <https://commons.apache.org/>! Your help is appreciated! Before you push a pull request, review this list: - Read the contribution guidelines <http://CONTRIBUTING.md> for this project. - Run a successful build using the default Maven <https://maven.apache.org/> goal with mvn; that's mvn on the command line by itself. - Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible but is a best-practice. - Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - Each commit in the pull request should have a meaningful subject line and body. Note that commits might be squashed by a maintainer on merge. ------------------------------ You can view, comment on, or merge this pull request online at: #568 Commit Summary - e45ac4d <e45ac4d> Add mockito to dependencyManagement File Changes (2 files <https://github.com/apache/commons-parent/pull/568/files>) - *M* .github/dependabot.yml <https://github.com/apache/commons-parent/pull/568/files#diff-dd4fbda47e51f1e35defb9275a9cd9c212ecde0b870cba89ddaaae65c5f3cd28> (4) - *M* pom.xml <https://github.com/apache/commons-parent/pull/568/files#diff-9c5fb3d1b7e3b0f54bc5c4182965c4fe1f9023d449017cece3005d3f90e8e4d8> (7) Patch Links: - https://github.com/apache/commons-parent/pull/568.patch - https://github.com/apache/commons-parent/pull/568.diff — Reply to this email directly, view it on GitHub <#568>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJB6N5YQYZA4TITBYMWIN32IT6FDAVCNFSM6AAAAABUPS43JWVHI2DSMVQWIX3LMV43ASLTON2WKOZSG43DKNRWGYYTQMA> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[raboof]

Note that I had to revert the Dependabot change because GitHub failed running the file.

Thanks! (for reference: 565af2f, in my defense 😄 the docs were wrong, filed github/docs#35818)

Also keep in mind that not all Commons components are stuck on Java 8 so doing this check would be counterproductive for Commons DbUtils for example.

That's a good point. With that in mind, we should probably not have the mockito version in the parent pom after all, since which version to pick depends on whether the project still supports Java 8 #570

[Sheikh1980]

[garydgregory]

-1 as previously discussed, some components depend on Java versions greater than 8.