Potential Vulnerability in Cloned Code#3352
Open
navnitan-7 wants to merge 1 commit into
Open
Conversation
Mirror upstream jQuery apachegh-2432 fix in vendored ajaxConvert: skip automatic script conversion on cross-domain responses unless dataType was explicit. Refs: jquery/jquery@2546bb3 Made-with: Cursor
|
Contributor
|
@navnitan-7 I don't think we need Jquery at all anymore and the only file of concern that this would impact thats still in use is Weather.html which could be rewritten in pure vanilla JS. Then we could just remove this entire static/jquery directory. Did you want to try and rewrite weather.html? Its fairly small and managable. |
Author
|
Thanks for the suggestion that makes sense. I agree that removing the dependency on jQuery and cleaning up the I'm happy to take a shot at rewriting jquery dependency into vanila js. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Patches CVE-2015-9251 (jQuery
ajax/ajaxConvertcross-domain script handling) in the vendored jQuery 1.12.4 copy atstatic/jquery/jquery.js.Changes
ajaxConvert, skip treating inferredscriptas the conversion target for cross-domain responses (matches upstream Add paw to existing Fact only if Fact wasn't used in Link command #2432).Impact
Reduces risk of executing attacker-controlled script content when
dataTypewas not explicitlyscripton cross-origin requests.References