[CALCITE-7405] Pre-process expressions for correlations before building projection in SqlToRelConverter #4779
+272
−68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuzifu666
reviewed
Jan 29, 2026
Member
xuzifu666
left a comment
xuzifu666
left a comment
There was a problem hiding this comment.
Need to fix CI error first.
| /.vscode/* | ||
|
|
||
| # IDEA | ||
| /out |
Author
There was a problem hiding this comment.
When I run with intellij, git detected a ton of extra files.
ian-bertolacci
force-pushed
the
CALCITE-7405-use-correct-input-for-convertNonAggregateSelectList
branch
2 times, most recently
from
6338b8f to
3784f65
Compare
…ng projection in SqlToRelConverter, simplify some gitignore paths
ian-bertolacci
force-pushed
the
CALCITE-7405-use-correct-input-for-convertNonAggregateSelectList
branch
from
3784f65 to
5314e24
Compare
|
ian-bertolacci
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To circumvent the bloat optimizations, it is necessary to provide the correlation variables (if they exist) to the builder.
The main change here is to accomplish the logic done in
SqlToRelConverter.getCorrelationswithout having built the Project node.In this way we (a) extract the correlation id to use for the RelBuilder, and (b) normalize/resolve the correlation ids and rewrite the expressions; all before invoking the RelBuilder.
I've done my best to reuse existing logic.
SqlToRelConverter.getCorrelationsandSqlToRelConverter.massageExpressionsForCorrelationrequire a lot of the same logic for resolving the correlation variables for the current scope, so that was moved to a common utility method (SqlToRelConverter.getCorrelationInfo).