Conversation
guide/blueprints/catalog/bundle.md
Outdated
There was a problem hiding this comment.
I would probably remove for searching as it's not clear what searching is in this context.
There was a problem hiding this comment.
Exceptions are -> The exceptions to this are
|
Thanks @drigodwin, all addressed. Should not be merged until after apache/brooklyn-server#743 . Also added explanation about the |
geomacy
left a comment
geomacy
left a comment
There was a problem hiding this comment.
One concern about the version comparison.
There was a problem hiding this comment.
Not keen on the "may" here, it seems too woolly - will Brooklyn increment the version or won't it, under what circumstances? Similarly below.
There was a problem hiding this comment.
This actually puts us at odds with OSGI - they define qualifier comparison to be simply lexicographic. For OSGI, 1.1.0.rc9-b > 1.1.0.rc10-a. If we are converting versions to bundle versions internally we need to match the OSGI version comparison rules. E.g. when brooklyn is working out what the latest version of a bundle is, we don't want Brooklyn choosing a different version than OSGI thinks is the latest.
There was a problem hiding this comment.
Will make this difference explicit -- as noted in apache/brooklyn-server#740 I think this is the right thing to do.
| you will need to use the mapped result (OSGi version syntax) in the manifest, | ||
| but should continue to use the Brooklyn-recommended syntax in the `catalog.bom`. | ||
|
|
||
| For those who are curious, the reason for the Brooklyn version syntax is to reconcile |
There was a problem hiding this comment.
👍 a great explanation to have
|
Thanks for great review comments. All but one incorporated, including discussion about equality @geomacy . The one that isn't is the statement about it "may" use co-bundling for searching. This is because we want to get there but currently aren't, or mostly aren't, so being precise here is hard and might become stale. Hopefully we'll soon always do it and can update that word in the docs! |
|
As apache/brooklyn-server#743 is merged I'm merging this. |
4 participants
docs re cleared-up OSGi/semver/maven versioning, as per ML
(this is WIP because the corresponding code is not yet written; however review here could be useful)