Skip to content

feat(ingress-controller): add imagePullSecrets support with global fallback#916

Merged
Baoyuantop merged 5 commits intoapache:masterfrom
ArnaudCHT:feature/imagepullsecret
Mar 26, 2026
Merged

feat(ingress-controller): add imagePullSecrets support with global fallback#916
Baoyuantop merged 5 commits intoapache:masterfrom
ArnaudCHT:feature/imagepullsecret

Conversation

@ArnaudCHT
Copy link
Copy Markdown
Contributor

@ArnaudCHT ArnaudCHT commented Dec 15, 2025

What

Add deployment.imagePullSecrets support in ingress-controller with fallback to global.imagePullSecrets.

Why

The ingress-controller deployment had no way to configure imagePullSecrets, forcing users to manually patch deployments or fork the chart.

Changes

  • Add deployment.imagePullSecrets configuration option
  • Falls back to global.imagePullSecrets if not set locally
  • Backward compatible and works standalone

#883

Testing

To test this PR, you can use the following commands:

# Test with global.imagePullSecrets
helm template . -s templates/deployment.yaml \
  --set 'global.imagePullSecrets[0].name=global-registry-secret'

# Test with deployment.imagePullSecrets (local override)
helm template . -s templates/deployment.yaml \
  --set 'deployment.imagePullSecrets[0].name=my-registry-secret'

# Test priority: deployment takes precedence over global
helm template . -s templates/deployment.yaml \
  --set 'global.imagePullSecrets[0].name=global-registry-secret' \
  --set 'deployment.imagePullSecrets[0].name=my-registry-secret'

# Test standalone (no imagePullSecrets)
helm template . -s templates/deployment.yaml

@AlinsRan
Copy link
Copy Markdown
Contributor

AlinsRan commented Mar 4, 2026

@ArnaudCHT Please resolve the conflict.

@ArnaudCHT
Copy link
Copy Markdown
Contributor Author

@ArnaudCHT Please resolve the conflict.

done

Comment thread charts/apisix-ingress-controller/README.md Outdated
Co-authored-by: martin-schulze-e2m <martin.schulze@e2m.energy>
@martin-schulze-e2m
Copy link
Copy Markdown

martin-schulze-e2m commented Mar 11, 2026

@AlinsRan @shreemaan-abhishek could you please approve the workflow run? Hopefully we don't need another round.

@martin-schulze-e2m
Copy link
Copy Markdown

@AlinsRan can you please give this another look?

@juzhiyuan
Copy link
Copy Markdown
Member

cc @Baoyuantop

Comment thread charts/apisix-ingress-controller/values.yaml
@Baoyuantop Baoyuantop requested review from AlinsRan and nic-6443 March 25, 2026 03:03
@Baoyuantop Baoyuantop merged commit 6c81314 into apache:master Mar 26, 2026
2 checks passed
@Hathoute
Copy link
Copy Markdown

@shreemaan-abhishek can we have a new release of ingress-controller (to include this) ? thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants