Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ under the License.
<version.errorprone>2.41.0</version.errorprone>
<version.hadoop>3.3.6</version.hadoop>
<version.log4j>2.25.3</version.log4j>
<version.opentelemetry>1.48.0</version.opentelemetry>
<version.opentelemetry>1.60.1</version.opentelemetry>
<version.powermock>2.0.9</version.powermock>
<version.slf4j>2.0.17</version.slf4j>
<version.thrift>0.17.0</version.thrift>
Expand Down Expand Up @@ -351,13 +351,13 @@ under the License.
<groupId>io.opentelemetry.javaagent</groupId>
<artifactId>opentelemetry-javaagent</artifactId>
<!-- This version was selected because it aligns with the version of open telemetry that Accumulo 2.1 is using. -->
<version>2.14.0</version>
<version>2.26.1</version>
</dependency>
<dependency>
<groupId>io.opentelemetry.proto</groupId>
<artifactId>opentelemetry-proto</artifactId>
<!-- This version was selected because it aligns with the version of protocol buffers that Accumulo 2.1 is using. -->
<version>1.3.2-alpha</version>
<version>1.10.0-alpha</version>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing this version causes ScanTracingIT to fail because it sets up the agent, the agent uses this library which uses protobuf. The protobuf version this library depends on differs from the protobuf version accumulo depends on.

When I run the test w/ these changes I see exceptions like the following. Not sure if this just at test problem or if this dep change will cause server side serialization of trace data to fail.

java.lang.NoClassDefFoundError: com/google/protobuf/RuntimeVersion$RuntimeDomain
	at io.opentelemetry.proto.collector.trace.v1.ExportTraceServiceRequest.<clinit>(ExportTraceServiceRequest.java:18)
	at org.apache.accumulo.test.tracing.TraceCollector$TraceHandler.handle(TraceCollector.java:60)
	at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:122)
	at org.eclipse.jetty.server.Server.handle(Server.java:563)
	at org.eclipse.jetty.server.HttpChannel$RequestDispatchable.dispatch(HttpChannel.java:1598)
	at org.eclipse.jetty.server.HttpChannel.dispatch(HttpChannel.java:753)
	at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:501)
	at org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:287)
	at org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:314)
	at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:100)
	at org.eclipse.jetty.io.SelectableChannelEndPoint$1.run(SelectableChannelEndPoint.java:53)
	at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:969)
	at org.eclipse.jetty.util.thread.QueuedThreadPool$Runner.doRunJob(QueuedThreadPool.java:1194)
	at org.eclipse.jetty.util.thread.QueuedThreadPool$Runner.run(QueuedThreadPool.java:1149)
	at java.base/java.lang.Thread.run(Thread.java:1583)
Caused by: java.lang.ClassNotFoundException: com.google.protobuf.RuntimeVersion$RuntimeDomain
	at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:641)
	at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:188)
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:526)
	... 15 more

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good information, I didn't now we had an IT for tracing. I'll look at this.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to revert the bom and proto dependencies to get the test to pass. I think I'm going to close this and see if we can address this another way.

</dependency>
<dependency>
<!-- legacy junit version specified here for dependency convergence -->
Expand Down