Removes running cache from coordinator#6244
Conversation
keith-turner
force-pushed
the
remove-running-cache
branch
from
7d71352 to
3ccccad
Compare
| LOG.warn( | ||
| "External compaction {} running in group {} on compactor {}," | ||
| + " but group not found in current configuration. Failing compaction...", | ||
| tec.getJob().getExternalCompactionId(), tec.getGroupName(), tec.getCompactor()); |
There was a problem hiding this comment.
Removed this functionality and not sure it should be carried forward in anyway. If a user has a compactor group A that is running long running compactions. They start a new compactor group B up and configure new long running compactions to go there. They want the compactions running in A to finish and will kill all processes in A when that happens. This code would interfere w/ that intent. Seems like if this done it should be user directed.
.../src/main/java/org/apache/accumulo/manager/compaction/coordinator/CompactionCoordinator.java
Show resolved
Hide resolved
.../src/main/java/org/apache/accumulo/manager/compaction/coordinator/CompactionCoordinator.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/apache/accumulo/manager/compaction/coordinator/CompactionCoordinator.java
Outdated
Show resolved
Hide resolved
| * @throws ThriftSecurityException when permission error | ||
| */ | ||
| @Override | ||
| public void updateCompactionStatus(TInfo tinfo, TCredentials credentials, |
There was a problem hiding this comment.
Agree with todo below. This can be removed. It was to update the status of the entry in the running cache, and to centralize logging of status updates in the coordinator.
There was a problem hiding this comment.
I will do that as a follow on, would be good to remove the RPC and the compactor calls to it.
2 participants
This contains uncommitted changes from many other PRs related to the running cache, so opening as a draft for now. This is the last PR in the series that actually removes the running cache, now that most of its usages are removed.