Removes the completed set from the coordinator#6241
Merged
keith-turner merged 2 commits intoapache:mainfrom Mar 25, 2026
Merged
Removes the completed set from the coordinator#6241keith-turner merged 2 commits intoapache:mainfrom
keith-turner merged 2 commits intoapache:mainfrom
Conversation
This change is made in support of apache#6217. Successfully ran all ITs that were changed.
keith-turner
commented
Mar 24, 2026
| } | ||
|
|
||
| client.tableOperations().flush(table1); | ||
| client.tableOperations().flush(table1, null, null, true); |
Contributor
Author
There was a problem hiding this comment.
This was an existing test bug I ran into while running ITs. Changed this code to wait for the flush instead of just initiate it. One test was hanging because it was trying to create 4 files, but this would not always happen.
dlmarion
approved these changes
Mar 25, 2026
.../src/main/java/org/apache/accumulo/manager/compaction/coordinator/CompactionCoordinator.java
Show resolved
Hide resolved
|
|
||
| this.fateClients = fateClients; | ||
|
|
||
| completed = ctx.getCaches().createNewBuilder(CacheName.COMPACTIONS_COMPLETED, true) |
Contributor
There was a problem hiding this comment.
Can CacheName.COMPACTIONS_COMPLETED be removed also?
Contributor
Author
There was a problem hiding this comment.
probably, I will look into that
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is made in support of #6217. Successfully ran all ITs that were changed.