Skip to content

test: smoke-test GCS upload flow #1287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
syntaxsdev wants to merge 2 commits into
base: main
Choose a base branch
from
Open

test: smoke-test GCS upload flow #1287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d767395
test: smoke-test GCS upload flow
syntaxsdev Apr 10, 2026
94fe4be
ci: switch pull-reviews from S3 to GCS, skip fork PRs
syntaxsdev Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions .github/workflows/pull-reviews.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,10 @@ permissions:

jobs:
preel:
if: github.event.pull_request.head.repo.fork == false
uses: ambient-code/pull-reviews/.github/workflows/review.yml@main
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
rg -nP '^\s*uses:\s*[^@\n]+@(?![0-9a-fA-F]{40}\b)[^\s]+' .github/workflows

Repository: ambient-code/platform

Length of output: 10148

Pin reusable workflow to commit SHA instead of @main.

Using @main allows silent updates that break reproducibility and create supply-chain risk. Pin to a full 40-character commit SHA.

Suggested change 
-    uses: ambient-code/pull-reviews/.github/workflows/review.yml@main
+    uses: ambient-code/pull-reviews/.github/workflows/review.yml@<commit-sha>
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/pull-reviews.yml at line 15, Replace the reusable workflow
reference that currently ends with "@main" (the string
"ambient-code/pull-reviews/.github/workflows/review.yml@main") with a pinned
full 40-character commit SHA from the ambient-code repository; locate the
desired commit in that repo, copy its full commit SHA, and substitute it for
"@main" so the workflow references
"ambient-code/pull-reviews/.github/workflows/review.yml@<40-char-commit-sha>" to
ensure reproducible, immutable execution.

with:
s3_bucket: pull-reviews
gcs_bucket: ambient-code-pull-reviews
gcp_project_id: ambient-code-platform
gcp_region: us-east5
gcp_workload_identity_provider: projects/888214980327/locations/global/workloadIdentityPools/github/providers/ambient-code-github-actions
secrets:
S3_ENDPOINT: ${{ secrets.S3_ENDPOINT }}
S3_ACCESS_KEY_ID: ${{ secrets.S3_ACCESS_KEY_ID }}
S3_SECRET_ACCESS_KEY: ${{ secrets.S3_SECRET_ACCESS_KEY }}
CDN_BASE_URL: ${{ secrets.CDN_BASE_URL }}
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,3 +80,4 @@ This project is licensed under the MIT License -- see the [LICENSE](LICENSE) fil
---

**Note:** This project was formerly known as "vTeam". Technical artifacts (image names, namespaces, API groups) still use "vteam" for backward compatibility.

Loading