Conversation
5939592 to
10a017a
Compare
Moves from a more cautious [tilde range](https://docs.npmjs.com/cli/v6/using-npm/semver#tilde-ranges-123-12-1) to [caret range](https://docs.npmjs.com/cli/v6/using-npm/semver#caret-ranges-123-025-004), because npm did it when I installed V6 and it doesn't seem risky because the dependency is GOVUK Frontend.
10a017a to
a56d42b
Compare
V6 removes `all.scss` so we use `_base.scss` for the check instead. Note: `all.scss` was removed in this pull request: alphagov/govuk-frontend#6412
See this section of the release notes for details: https://github.com/alphagov/govuk-frontend/releases/tag/v6.0.0#:~:text=Use%20GOV.UK%20brand%20colours
In https://github.com/alphagov/govuk-frontend/releases/tag/v6.1.0 there's a recomended change to Sass import paths.
Introduce a service navigation partial, to match the design system component and move the links in the header out into it. This is the service navigation component: https://design-system.service.gov.uk/components/service-navigation/ As part of this, the service-level links have now been moved out into the service navigation component. This updates the header classes to match changes made by the design system team when they did this work. See this pull request for details of that work: alphagov/govuk-frontend#6423
The old ones were removed in this pull request so we no longer need this flag: alphagov/govuk-frontend#6390
If you're not a rubyist, it's useful to know how to run the tests.
a56d42b to
361b9e3
Compare
|
@tombye - looks good mostly, however on the mobile-wallet-tech-docs the service links don't highlight the active section correctly: This is possibly due to custom layouts applied to the create the table of contents? |
|
@jamescarr28 I managed to get your docs running locally so can see what you mean. I can see the same thing happening on the current prod site: https://docs.wallet.service.gov.uk/ too. Digging in the code, it's the use of the There's a bit in the logic where the It seems sensible to extend the |
@tombye - yeah completely understand, not something to fix as part of this - only highlighted as an example of teams maybe wanting some lead in time (in the new service navigation this is a much more obvious bug than the old one 😄 ) |
|
@tombye - I don't seem to have permission to approve - but I'm happy that this is good to go in once we've given people a chance to check it works for them. I'd say 4 weeks should be enough if @NathanD-GDS agrees? I'd say Monday 19th April looks good |
These changes will mandate the new branding for all downstream tech docs so do a pre-release first to let people check for any resulting problems and feed back.
7fe791c to
1ceab2d
Compare


What’s changed
This bumps the version of Design System (GOV.UK Frontend) used by this gem to V6 and packages it up as a beta release, to allow downstream projects time to try it out.
Identifying a user need
Public documentation should have the GOV.UK brand, so users get confirmation they're looking at the right thing because it matches both the service and www.gov.uk. Non-public documentation should be consistent with other docs, as much as possible, for similar reasons.
Notes for reviewers
Because the new branding style, which moves the header links to a service navigation component below the GOV.UK logo, is now mandatory, I'm calling this a major version bump.
Other than those changes, the other things changed are:
Examples of downstream projects with this version of the gem
Based on the spreadsheet of tech docs using the tech docs gem across GDS
GDS Way
WCAG Primer