Allow custom model names for Dense, Sparse embeddings, fix Sparse Embeddings#146
Open
tomaarsen wants to merge 1 commit intoalibaba:mainfrom
Open
Allow custom model names for Dense, Sparse embeddings, fix Sparse Embeddings#146tomaarsen wants to merge 1 commit intoalibaba:mainfrom
tomaarsen wants to merge 1 commit intoalibaba:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
Pull Request overview
DefaultLocalSparseEmbeddingandDefaultLocalDenseEmbedding_get_modelacross DenseEmbedding, SparseEmbedding, and ReRanker via a_get_model_classpropertyencode_query&encode_documentexists for both SparseEncoder and SentenceTransformer._manual_sparse_encodefor older Sentence Transformer: I would recommend requiring at least Sentence Transformers v5.0 so the SparseEncoder can be used.SentenceTransformerReRankerwithDefaultLocalReRankerin the docs, as the previous doesn't exist anymore.Details:
This PR extends the support for local dense, sparse, and reranker models a good bit. I've had some installation issues, so I'm unable to properly run the tests at the moment, but you should get much clearer results for the SparseEmbedding class. I also simplified the sparse embedding post-processing using
model.decode, which also removes some issues with SparseCUDA and SparseCPU not implementing all operations.Please do let me know if you have any questions.