fix: align Python version requirements across documentation and configuration#140
Open
Junio243 wants to merge 3 commits intoalibaba:mainfrom
Open
fix: align Python version requirements across documentation and configuration#140Junio243 wants to merge 3 commits intoalibaba:mainfrom
Junio243 wants to merge 3 commits intoalibaba:mainfrom
Conversation
Change requires-python from '>=3.9' to '>=3.10,<3.13' to match the actual wheel availability (cp310, cp311, cp312) and the README documentation.
Change from 'Python >= 3.9' to 'Python 3.10 - 3.12' to match the actual wheel availability and package requirements.
There was a problem hiding this comment.
Pull request overview
This PR aligns Python version requirements across documentation and configuration files to accurately reflect the actual supported versions. Previously, the documentation and configuration were inconsistent, with pyproject.toml declaring >=3.9 while only wheels for Python 3.10-3.12 were being built, causing confusing installation errors for Python 3.9 users.
Changes:
- Updated
pyproject.tomlto specifyrequires-python = ">=3.10,<3.13"to match actual wheel availability - Updated
CONTRIBUTING.mdto reflect Python 3.10-3.12 support instead of Python ≥ 3.9 - Fixed the git clone URL in
CONTRIBUTING.mdfrom a placeholder to the actual repository URL
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pyproject.toml | Updated requires-python from >=3.9 to >=3.10,<3.13 to match cibuildwheel configuration |
| CONTRIBUTING.md | Updated Python version prerequisite from ≥ 3.9 to 3.10 - 3.12 and fixed repository clone URL |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
There is an inconsistency between the documented Python version support and the actual wheel availability:
requires-python = ">=3.9"cp310,cp311,cp312User Impact
This creates a frustrating experience:
Solution
This PR aligns all Python version declarations to accurately reflect the actual supported versions:
Changes Made
pyproject.toml
requires-python = ">=3.9"torequires-python = ">=3.10,<3.13"[tool.cibuildwheel]CONTRIBUTING.md
Why
<3.13?The upper bound prevents installation attempts on Python 3.13+ where no wheels exist yet. This gives clearer error messages and prevents users from attempting installations that will fail.
Type of Change
Benefits
Related Issues
Note: If Python 3.9 support is desired in the future, this would require either: