feat: add support for langchain embedding by minimAluminiumalism · Pull Request #157 · alibaba/loongsuite-python-agent

minimAluminiumalism · 2026-03-26T03:59:56Z

Description

Implement #142

Semconv ref https://opentelemetry.io/docs/specs/semconv/gen-ai/gen-ai-spans/#embeddings

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How Has This Been Tested?

instrumentation-loongsuite/loongsuite-instrumentation-langchain/tests/test_embedding_spans.py

Does This PR Require a Core Repo Change?

Yes. - Link to PR:
No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

Followed the style guidelines of this project
Changelogs have been updated
Unit tests have been added
Documentation has been updated

…stream methods

…gent

…essor span support Automatically instrument BaseDocumentCompressor subclasses to emit rerank spans with OpenTelemetry semantic conventions. Uses __init_subclass__ hook to cover classes defined after instrumentation.

…gent

Copilot

Pull request overview

Adds LangChain Embeddings instrumentation to loongsuite-instrumentation-langchain, emitting GenAI embedding spans via opentelemetry-util-genai per the GenAI semantic conventions.

Changes:

Introduces an Embeddings patch that wraps embed_* / aembed_* on all current and future langchain_core.embeddings.Embeddings subclasses.
Adds a comprehensive embedding span test suite (sync/async, error cases, dedup/proxy behavior, late subclassing, uninstrumentation).
Documents embedding spans in the README and records the feature in the changelog.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
instrumentation-loongsuite/loongsuite-instrumentation-langchain/src/opentelemetry/instrumentation/langchain/internal/patch_embedding.py	New patch module that wraps Embeddings methods and emits embedding spans through `ExtendedTelemetryHandler`.
instrumentation-loongsuite/loongsuite-instrumentation-langchain/src/opentelemetry/instrumentation/langchain/init.py	Wires embedding instrumentation into the instrumentor’s instrument/uninstrument lifecycle.
instrumentation-loongsuite/loongsuite-instrumentation-langchain/tests/test_embedding_spans.py	New tests validating span creation, attributes, errors, deduplication, and uninstrument behavior for embeddings.
instrumentation-loongsuite/loongsuite-instrumentation-langchain/README.md	Adds “Embedding” span kind and its key attributes to the supported spans table.
instrumentation-loongsuite/loongsuite-instrumentation-langchain/CHANGELOG.md	Notes embedding span support in the Unreleased “Added” section.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-31T01:08:12Z

...umentation-langchain/src/opentelemetry/instrumentation/langchain/internal/patch_embedding.py

+    # 2. Install an __init_subclass__ hook so future subclasses are
+    #    patched automatically.
+    _original_init_subclass = Embeddings.__dict__.get("__init_subclass__")
+
+    @classmethod  # type: ignore[misc]


instrument_embeddings() is not idempotent: if the instrumentor’s instrument() is called multiple times (there is an existing test that does this), _original_init_subclass gets overwritten with the already-patched hook. A subsequent uninstrument_embeddings() will then restore Embeddings.__init_subclass__ to the patched hook instead of the true original, meaning future subclasses can still be auto-patched after uninstrumentation. Consider guarding against re-instrumentation (e.g., a module-level “already_instrumented” flag / storing the original only once) and skipping re-installing the hook when it’s already patched by this module.

Copilot · 2026-03-31T01:08:13Z

...umentation-langchain/src/opentelemetry/instrumentation/langchain/internal/patch_embedding.py

+    """Extract a model name from an Embeddings instance (if available)."""
+    for attr in ("model", "model_name", "model_id", "deployment_name"):
+        val = getattr(instance, attr, None)
+        if val and isinstance(val, str):
+            return val
+    return ""
+
+


_extract_embedding_model() returns an empty string when no model attribute is found, but EmbeddingInvocation.request_model is used for span naming and (when non-empty) the required gen_ai.request.model attribute. An empty string yields a span name like "embeddings " and omits the model attribute entirely. Consider falling back to a more informative value (e.g., the embeddings class name) to avoid producing an effectively unnamed model in spans.

Suggested change

"""Extract a model name from an Embeddings instance (if available)."""

for attr in ("model", "model_name", "model_id", "deployment_name"):

val = getattr(instance, attr, None)

if val and isinstance(val, str):

return val

return ""

"""Extract a model name from an Embeddings instance (if available).

If no explicit model attribute is found, fall back to the class name

so that spans and attributes never use an empty model identifier.

"""

for attr in ("model", "model_name", "model_id", "deployment_name"):

val = getattr(instance, attr, None)

if val and isinstance(val, str):

return val

# Fallback: use the embeddings class name as a best-effort model identifier

cls = type(instance)

return cls.__name__ or repr(cls)

Cirilla-zmh

Thanks for this great PR! Some comments should be resolved before getting merged.

Cirilla-zmh · 2026-04-01T09:51:55Z

instrumentation-loongsuite/loongsuite-instrumentation-langchain/CHANGELOG.md


 ### Added

+- Langchain embedding span support([#157](https://github.com/alibaba/loongsuite-python-agent/pull/157))


Suggested change

- Langchain embedding span support([#157](https://github.com/alibaba/loongsuite-python-agent/pull/157))

- LangChain embedding span support

([#157](https://github.com/alibaba/loongsuite-python-agent/pull/157))

Cirilla-zmh · 2026-04-01T09:54:52Z

...umentation-langchain/src/opentelemetry/instrumentation/langchain/internal/patch_embedding.py

+    return wrapper
+
+
+def _make_aembed_query_wrapper(


Why not reuse _make_aembed_documents_wrapper?

I'll check these comments tomorrow ：)

Cirilla-zmh · 2026-04-01T10:07:20Z

@minimAluminiumalism Hey! Thank you for your outstanding contributions over time. We are very pleased to invite you to become an approver for loongsuite-python-agent. If you are willing, you can leave an 👍 under this comment, and I’ll be happy to submit a PR for this.

If it’s convenient for you, you’re also welcome to join our DingTalk group and contact “希铭” in the group. We look forward to connecting with you more closely.

minimAluminiumalism added 6 commits January 28, 2026 19:23

fix(agno): fix aresponse missing await and double wrapped() calls in …

831fdf4

…stream methods

fix cicd pipeline failures and apply agents suggestions

b2a3efb

Merge branch 'main' of https://github.com/alibaba/loongsuite-python-a…

f3023e5

…gent

chore: lint fix

b3d08e3

Merge branch 'main' of https://github.com/alibaba/loongsuite-python-a…

2917bdb

…gent

github-actions bot assigned 123liuziming, Cirilla-zmh and ralf0131 Mar 26, 2026

github-actions bot requested review from 123liuziming, Cirilla-zmh and ralf0131 March 26, 2026 04:00

feat: add support for langchain embedding

7a72725

minimAluminiumalism force-pushed the main branch from ca63521 to 7a72725 Compare March 26, 2026 04:00

ralf0131 requested a review from Copilot March 31, 2026 01:02

Copilot started reviewing on behalf of ralf0131 March 31, 2026 01:02 View session

Copilot AI reviewed Mar 31, 2026

View reviewed changes

alibaba deleted a comment from Copilot AI Apr 1, 2026

Cirilla-zmh requested changes Apr 1, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add support for langchain embedding#157

feat: add support for langchain embedding#157
minimAluminiumalism wants to merge 7 commits intoalibaba:mainfrom
minimAluminiumalism:main

minimAluminiumalism commented Mar 26, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 31, 2026

Uh oh!

Copilot AI Mar 31, 2026

Uh oh!

Cirilla-zmh left a comment

Uh oh!

Cirilla-zmh Apr 1, 2026

Uh oh!

Cirilla-zmh Apr 1, 2026 •

edited

Loading

Uh oh!

minimAluminiumalism Apr 1, 2026

Uh oh!

Cirilla-zmh commented Apr 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants


		### Added

		- Langchain embedding span support([#157](https://github.com/alibaba/loongsuite-python-agent/pull/157))

	- Langchain embedding span support([#157](https://github.com/alibaba/loongsuite-python-agent/pull/157))
	- LangChain embedding span support
	([#157](https://github.com/alibaba/loongsuite-python-agent/pull/157))

Conversation

minimAluminiumalism commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

How Has This Been Tested?

Does This PR Require a Core Repo Change?

Checklist:

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

Cirilla-zmh left a comment

Choose a reason for hiding this comment

Uh oh!

Cirilla-zmh Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

Cirilla-zmh Apr 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

minimAluminiumalism Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

Cirilla-zmh commented Apr 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

minimAluminiumalism commented Mar 26, 2026 •

edited

Loading

Cirilla-zmh Apr 1, 2026 •

edited

Loading