Switch sha1 calculations done by rust sha1 crate to openssl#42
Closed
Switch sha1 calculations done by rust sha1 crate to openssl#42
Conversation
algesten
force-pushed
the
main
branch
2 times, most recently
from
8c3903e to
0ded9f5
Compare
algesten
force-pushed
the
feature/full-openssl
branch
from
07a5709 to
3d7a71e
Compare
|
I was reading on Discord that the reason for switching to the OpenSSL SHA-1 implementation is because of the issue of the RustCrypto crate not support ASM on some platforms, notably MSVC, which has a noticeable impact on performance. Hopefully this can help: RustCrypto/hashes#450. |
Owner
Author
|
Thanks! Truth to be told, I don't know if the OpenSSL SHA1 is making any performance difference on Windows. The inline ASM will certainly solve this. I was looking at how to implement the SHA1 in inline ASM but decided it was slightly beyond the scope of what I wanted to attempt right now. |
algesten
force-pushed
the
main
branch
5 times, most recently
from
a491dda to
32b0f89
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.