Skip to content

Support having Root extend from custom trait#8

Open
feynmanliang wants to merge 1 commit intoaishfenton:masterfrom
feynmanliang:add-parent
Open

Support having Root extend from custom trait#8
feynmanliang wants to merge 1 commit intoaishfenton:masterfrom
feynmanliang:add-parent

Conversation

@feynmanliang
Copy link
Copy Markdown

@feynmanliang feynmanliang commented May 23, 2017

Closes #6


This change is Reviewable

@feynmanliang
Copy link
Copy Markdown
Author

@aishfenton is this project still active?

@aishfenton
Copy link
Copy Markdown
Owner

Yes sorry still alive, let me review and incorporate now.

@TugdualSarazin
Copy link
Copy Markdown
Contributor

It doesn't compile if the parent object is not in the same package.

it should "support parent, and make the root element extend it" in {
    @fromSchemaResource("/simple.json", parent=Some("argus.macros.test.ParentTest"))
    object Schema

    implicitly[Schema.Root <:< argus.macros.test.ParentTest]
}
package argus.macros.test

trait ParentTest

@feynmanliang
Copy link
Copy Markdown
Author

@TugdualSarazin thanks! I'll take a look at this sometime this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants