fix: only render set PDB field to fix schema validation by nicknikolakakis · Pull Request #4511 · agones-dev/agones

nicknikolakakis · 2026-04-12T07:44:44Z

What type of PR is this?

/kind bug

What this PR does / Why we need it:

The PDB templates in controller.yaml, extensions-deployment.yaml, ping.yaml, and service/allocation.yaml unconditionally render both minAvailable and maxUnavailable fields. When only one is configured (the default sets minAvailable: 1), the other renders as an empty/null value, violating the PDB oneOf schema constraint.

This wraps each field in a conditional so only the field with a value is included in the rendered manifest.

Which issue(s) this PR fixes:

Fixes #4507

Special notes for your reviewer:

Verified with helm template:

Default values: only minAvailable: 1 rendered (no empty maxUnavailable)
With maxUnavailable set and minAvailable unset: only maxUnavailable rendered
With both set: existing mutual-exclusivity check + JSON schema validation both reject it

The PDB templates unconditionally rendered both minAvailable and maxUnavailable fields, even when one was empty. This violates the PDB schema which requires exactly one of the two fields. Wrap each field in a conditional so only the field with a value is rendered. Fixes agones-dev#4507 Signed-off-by: Nick Nikolakakis <nonicked@protonmail.com>

nicknikolakakis · 2026-04-12T07:46:21Z

Hi, the agones-dev-pull-request-build (agones-images) check failed but I can't access the Cloud Build logs. Could a maintainer take a look and let me know if there's something I need to fix, or if this just needs approval to run on a fork?

Also, I'd like to join the agones-discuss mailing list to access build logs - is https://groups.google.com/forum/#!forum/agones-discuss still the right link?

Sivasankaran25 · 2026-04-12T12:34:39Z

/gcbrun

agones-bot · 2026-04-12T12:43:55Z

Build Failed 😭

Build Id: 1505a049-137c-4587-8ffc-8f8b1047a0ab

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

Remove empty maxUnavailable fields from the generated install.yaml to match the corrected Helm templates. Signed-off-by: Nick Nikolakakis <nonicked@protonmail.com>

Sivasankaran25 · 2026-04-12T15:59:06Z

/gcbrun

agones-bot · 2026-04-12T16:08:21Z

Build Failed 😭

Build Id: 05912e0e-70d4-4e0b-9d51-a8552f79be7e

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2026-04-12T16:10:15Z

Hi, the agones-dev-pull-request-build (agones-images) check failed but I can't access the Cloud Build logs. Could a maintainer take a look and let me know if there's something I need to fix, or if this just needs approval to run on a fork?

Also, I'd like to join the agones-discuss mailing list to access build logs - is https://groups.google.com/forum/#!forum/agones-discuss still the right link?

Is the link failing for you? Works fine for me.

markmandel · 2026-04-12T16:11:41Z

You'll need to run make gen-install to regenerate the index.yaml - that's what the test failure is.

Signed-off-by: Nick Nikolakakis <nonicked@protonmail.com>

markmandel · 2026-04-13T01:34:10Z

/gcbrun

agones-bot · 2026-04-13T02:31:29Z

Build Succeeded 🥳

Build Id: 934e0363-9492-4021-9bb7-b0e9bd2eba5a

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.58.0-dev-cff5818
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.58.0-dev-cff5818
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.58.0-dev-cff5818-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.58.0-dev-cff5818
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.58.0-dev-cff5818
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.58.0-dev-cff5818
Linux C++ SDK (build): agonessdk-1.58.0-dev-cff5818-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.58.0-dev-cff5818.zip

A preview of the website (the last 30 builds are retained):

https://cff5818-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4511/head:pr_4511 && git checkout pr_4511
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.58.0-dev-cff5818

lacroixthomas · 2026-04-15T22:18:52Z

/gcbrun

agones-bot · 2026-04-15T23:51:06Z

Build Succeeded 🥳

Build Id: 2debae6d-8163-453a-a546-bb7753b4983a

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.58.0-dev-6f7ced5
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.58.0-dev-6f7ced5
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.58.0-dev-6f7ced5-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.58.0-dev-6f7ced5
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.58.0-dev-6f7ced5
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.58.0-dev-6f7ced5
Linux C++ SDK (build): agonessdk-1.58.0-dev-6f7ced5-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.58.0-dev-6f7ced5.zip

A preview of the website (the last 30 builds are retained):

https://6f7ced5-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4511/head:pr_4511 && git checkout pr_4511
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.58.0-dev-6f7ced5

github-actions bot added kind/bug These are bugs. size/S labels Apr 12, 2026

fix: update install.yaml to match fixed PDB templates

22799b5

Remove empty maxUnavailable fields from the generated install.yaml to match the corrected Helm templates. Signed-off-by: Nick Nikolakakis <nonicked@protonmail.com>

github-actions bot added the size/M label Apr 12, 2026

fix: regenerate install.yaml with make gen-install

cff5818

Signed-off-by: Nick Nikolakakis <nonicked@protonmail.com>

markmandel mentioned this pull request Apr 12, 2026

build: improve gen-install and gen-api-docs failure messages #4512

Merged

markmandel added the area/operations Installation, updating, metrics etc label Apr 12, 2026

markmandel approved these changes Apr 13, 2026

View reviewed changes

markmandel enabled auto-merge (squash) April 13, 2026 02:43

Merge branch 'main' into fix/4507-pdb-schema-validation

6f7ced5

markmandel merged commit dde9dab into agones-dev:main Apr 15, 2026
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: only render set PDB field to fix schema validation#4511

fix: only render set PDB field to fix schema validation#4511
markmandel merged 4 commits intoagones-dev:mainfrom
nicknikolakakis:fix/4507-pdb-schema-validation

nicknikolakakis commented Apr 12, 2026

Uh oh!

nicknikolakakis commented Apr 12, 2026

Uh oh!

Sivasankaran25 commented Apr 12, 2026

Uh oh!

agones-bot commented Apr 12, 2026

Uh oh!

Sivasankaran25 commented Apr 12, 2026

Uh oh!

agones-bot commented Apr 12, 2026

Uh oh!

markmandel commented Apr 12, 2026

Uh oh!

markmandel commented Apr 12, 2026

Uh oh!

markmandel commented Apr 13, 2026

Uh oh!

agones-bot commented Apr 13, 2026

Uh oh!

lacroixthomas commented Apr 15, 2026

Uh oh!

agones-bot commented Apr 15, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

nicknikolakakis commented Apr 12, 2026

Uh oh!

nicknikolakakis commented Apr 12, 2026

Uh oh!

Sivasankaran25 commented Apr 12, 2026

Uh oh!

agones-bot commented Apr 12, 2026

Uh oh!

Sivasankaran25 commented Apr 12, 2026

Uh oh!

agones-bot commented Apr 12, 2026

Uh oh!

markmandel commented Apr 12, 2026

Uh oh!

markmandel commented Apr 12, 2026

Uh oh!

markmandel commented Apr 13, 2026

Uh oh!

agones-bot commented Apr 13, 2026

Uh oh!

lacroixthomas commented Apr 15, 2026

Uh oh!

agones-bot commented Apr 15, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants