fix: unset claims max log range (0.8)#1526
Merged
arnaubennassar merged 1 commit intorelease/0.8from Mar 5, 2026
Merged
Conversation
🔄 Changes Summary - Added a configurable UnsetClaimsMaxLogBlockRange setting that proactively chunks eth_getLogs queries for unset-claims fetching, avoiding block range errors before they occur - Refactored AgglayerBridgeL2Reader to support proactive chunking via a new constructor NewAgglayerBridgeL2ReaderWithMaxLogBlockRange, while preserving existing reactive fallback chunking behavior - Added a new regex to ParseMaxRangeFromError to handle the "eth_getLogs is limited to a 10,000 range" error format (with comma-formatted numbers)⚠️ Breaking Changes - None 📋 Config Updates - 🧾 New field added to [AggSender] and [Validator] sections: ```toml # Max block range per eth_getLogs call for unset-claims queries. 0 disables proactive chunking. UnsetClaimsMaxLogBlockRange = 0 ``` Default is 0 (disabled), preserving existing reactive fallback behavior. ✅ Testing - 🤖 Automatic: Unit tests added in bridgesync/agglayer_bridge_l2_reader_test.go covering proactive chunking, fallback chunking, and the new error regex in common/errors_test.go 🐞 Issues - Closes #1517 🔗 Related PRs - N/A 📝 Notes - When UnsetClaimsMaxLogBlockRange > 0, proactive chunking kicks in if toBlock - fromBlock >= maxRange. Each chunk still falls back to reactive chunking if the RPC returns a smaller limit. - The new eth_getLogs is limited to a N,000 range regex handles comma-formatted numbers (e.g., 10,000) by stripping commas before parsing. --------- Co-authored-by: Luke Thorne <luke@conduit.xyz>
joanestebanr
approved these changes
Mar 5, 2026
arnaubennassar
changed the title
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-pick of #1520 (
feat: unset claims max log range) ontorelease/0.8.UnsetClaimsMaxLogBlockRangeto[AggSender]and[Validator]config sectionseth_getLogsqueries for unset-claims fetching to avoid block range errors0(disabled), preserving existing reactive fallback behaviorChanges
Conflict resolution:
BlockFinalityForL1InfoTree,TriggerCertMode,TriggerEpochBased, andTriggerASAPfields/config don't exist inrelease/0.8, so onlyUnsetClaimsMaxLogBlockRangewas added from the cherry-pick.🤖 Generated with Claude Code