Skip to content

Improve settings page UX#43

Merged
afurm merged 1 commit intomainfrom
codex/improve-settings-page-ux
May 8, 2026
Merged

Improve settings page UX#43
afurm merged 1 commit intomainfrom
codex/improve-settings-page-ux

Conversation

@afurm
Copy link
Copy Markdown
Owner

@afurm afurm commented May 8, 2026

Closes #42.

Summary

  • Reworked settings into shadcn Tabs for OpenAI, Advanced, and Board flows.
  • Hid board-only search, filters, and New task actions while viewing settings.
  • Split save behavior by tab so board saves do not send provider patches.
  • Added inline validation for advanced numeric fields and empty focus-area names.
  • Tightened focus-area rows for responsive layouts and focused newly added rows automatically.

Validation

  • npm run typecheck
  • npm test -- --run src/client/components/SettingsView.test.tsx src/client/App.test.tsx
  • npm run build
  • git diff --check
  • Browser smoke at desktop and 390px mobile on http://localhost:5174 for settings tabs, hidden board actions, and Add area autofocus.

@afurm afurm marked this pull request as ready for review May 8, 2026 07:27
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bb698508b6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

const supportedModels = useMemo(() => accountInfo?.models ?? [], [accountInfo]);
const openAiReady = Boolean(providerStatus?.configured || authState?.configured);
const login = authState?.login;
const accountMetadataLoading = authState === null && accountInfo === null;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Stop treating failed metadata fetches as infinite loading

When the initial onGetOpenAiAuth() and onGetOpenAiAccountInfo() calls both reject (for example during a transient backend outage), both states stay null because the Promise.allSettled handler only updates fulfilled results, so accountMetadataLoading remains true forever and the OAuth account panel never appears. In that state users lose the Connect/Refresh controls and have no in-page recovery path besides a full reload.

Useful? React with 👍 / 👎.

@afurm afurm merged commit 1f15e96 into main May 8, 2026
2 checks passed
@afurm afurm deleted the codex/improve-settings-page-ux branch May 8, 2026 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve settings page UX and shadcn flow

1 participant