Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bb698508b6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const supportedModels = useMemo(() => accountInfo?.models ?? [], [accountInfo]); | ||
| const openAiReady = Boolean(providerStatus?.configured || authState?.configured); | ||
| const login = authState?.login; | ||
| const accountMetadataLoading = authState === null && accountInfo === null; |
There was a problem hiding this comment.
Stop treating failed metadata fetches as infinite loading
When the initial onGetOpenAiAuth() and onGetOpenAiAccountInfo() calls both reject (for example during a transient backend outage), both states stay null because the Promise.allSettled handler only updates fulfilled results, so accountMetadataLoading remains true forever and the OAuth account panel never appears. In that state users lose the Connect/Refresh controls and have no in-page recovery path besides a full reload.
Useful? React with 👍 / 👎.
Closes #42.
Summary
Validation