Open
Conversation
While our link was using the numeric slug, the link text was using a pattern that resulted in a 404. This switches to use the numeric slug.
Contributor
Author
|
@rambleraptor , I think we moved to numeric slugs without a text-based alias? All I know is that the guidance was suggesting a text-based URL that was resulting in 404s. |
Contributor
Author
|
Hmm, if this change is correct, than I think perhaps https://aep.dev/tooling/linter/rules/0162/ may need an update, too? I see this guidance does still refer to word-based slugs, so possibly that deserves attention? |
Member
|
I think we're trying to use the non-numeric slugs. Both of them should work regardless. |
Member
|
@rofrankel too |
Member
|
I think in this particular case we shouldn't update those - that should probably always point at But those are examples, correct? so really it comes down to whether the linter accepts them (I presume it does). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While our link was using the numeric slug, the link text was using a pattern that resulted in a 404. This switches to use the numeric slug.
🍱 Types of changes
What types of changes does your code introduce to AEP? Put an
xin the boxesthat apply
📋 Your checklist for this pull request
Please review the AEP Style and Guidance for
contributing to this repository.
General
references AEPs
correctly.
(usually
prettier -w .)