-
Notifications
You must be signed in to change notification settings - Fork 1.4k
docs: color scheme switcher #9403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Build successful! 🎉 |
|
Nice! Putting the whole app into the colorscheme that isn't your OS colorscheme causes the search overlay to be wrong |
|
Build successful! 🎉 |
|
Noticed that the bottom of the page https://d5iwopk28bdhl.cloudfront.net/pr/fde4d39fe83e28091754a70459dbaa4c7acdc8b2/ there is no settings, also the Also, some things are meeting contrast, like the Explore Components button. It's like some things switched, but not others if my computer is in dark mode but my settings are in light mode :-/ |
|
Build successful! 🎉 |
|
It still won't put the search dialog into the correct color scheme, is that alright? |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
snowystinger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a little unfortunate that it flickers if your computer is in dark mode on a page load
snowystinger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we visibility hidden the button until we know the current color scheme?

Adds a color scheme switcher to the header for React Spectrum pages.
✅ Pull Request Checklist:
📝 Test Instructions:
Test the color switcher on S2 docs pages (including the home page).
🧢 Your Project: