Add variable font value syntax support and fix multiple bugs#1818
Merged
skef merged 5 commits intoaddfeaturesfrom Feb 26, 2026
Merged
Add variable font value syntax support and fix multiple bugs#1818skef merged 5 commits intoaddfeaturesfrom
skef merged 5 commits intoaddfeaturesfrom
Conversation
Implements variable font positioning value syntax by introducing lexer modes to disambiguate axis unit suffixes (d, u, n) from glyph names. Grammar changes: - Add LocationDefMode for parsing locationDef statements - Add VarValue mode for parsing variable positioning values - Remove AXISUNIT from default mode to prevent conflicts - Update ANTLR version from 4.13.1 to 4.13.2 Bug fixes: - Fix iterator loops using .size (capacity) instead of .cnt (count) in hot.cpp, cffread_abs.cpp, t1read.cpp, tx_shared.cpp, cffwrite - Fix buffer underflow protection in type1.c - Fix error context reporting for missing include files (moved set_context after file validation in FeatVisitor.cpp) - Add NULL check in dynarr.c before freeing Testing: - Add comprehensive variable font tests with 8 positioning formats - Add HarfBuzz shaping verification tests (requires uharfbuzz) - Add regression test for missing include error messages - All 419 tests pass 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Updated the CodeQL workflow to use `pip3 install .` instead of the obsolete `python3 setup.py build` command. The project now uses pyproject.toml with scikit-build-core for building. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Restored the pull_request branch restriction to only run CodeQL on PRs targeting the develop branch. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
The new variable font value tests (test_var_pairwise_kerning and test_var_mark_positioning) require uharfbuzz for shaping validation. Added it to requirements-dev.txt so CI tests can run successfully. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements variable font positioning value syntax by introducing lexer modes to disambiguate axis unit suffixes (d, u, n) from glyph names.
Grammar changes:
Bug fixes:
Testing:
🤖 Generated with Claude Code
Description
Replace this text with a description of your changes, indicating whether
it is a bug fix, enhancement, etc. and which general area(s) are affected
(documentation, specific tool, group of tools, tests, etc.).
If the contribution closes (fixes, resolves) a specific open
issue, please link
the issue.
Checklist: