chore!: remove unused files part 2#5282
Open
AJPfleger wants to merge 6 commits intoacts-project:mainfrom
Open
Conversation
github-actions
bot
added
Component - Core
Contributor
github-actions
bot
added
the
Infrastructure
|
Contributor
|
this has picked up conflicts @AJPfleger |
AJPfleger
commented
Apr 21, 2026
Comment on lines
-78
to
-79
| "GeometryModule.h", | ||
| "runtime_geometry_modules.md", |
Contributor
Author
There was a problem hiding this comment.
@paulgessinger, I saw you added these 2 files to be removed in the next breaking release with #5253. Is this correct?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deletes the unused files that are detected in:
Python#5075and have been missed in:
I would suggest to add them for now to the ignore list in the unused file check and remove the entries with this PR together with the files. Therefore blocked by:
Python#5075Core/include/Acts/EventData/detail/ParameterTraits.hppThis one is ancient. Hasn't been updated for 6 years. It was missed in the file check, because
Core/include/Acts/Propagator/Propagator.hppincludedParameterTraitsfromCore/include/Acts/Propagator/detail/ParameterTraits.hpp. This was removed in:Core/include/Acts/Seeding/PathSeeder.hppThis was only used by
Tests/UnitTests/Core/Seeding/PathSeederTest.cpp, which was removed in:Tests/CommonHelpers/include/ActsTests/CommonHelpers/TestSpacePoint.hppThis was only used by
Tests/UnitTests/Core/SpacePointFormation/SpacePointBuilderTests.cpp, which was removed in: