feat: Demonstrator for MillePede alignment of ACTS Kalman tracks#5256
feat: Demonstrator for MillePede alignment of ACTS Kalman tracks#5256andiwand merged 23 commits intoacts-project:mainfrom
Conversation
|
Wow, the CI even checks the PR title? |
|
Amazing! |
|
Pausing updates for now to allow for review (sorry for the big PR - once the first bits were in place the extra features just kept coming by themselves 😇 ) |
SonarQube is an &*$% minor cosmetics
ff4d2f2 to
38176e7
Compare
|
It is also on my list but I didn't get to it yet. Let me also ping the review channel on MM https://mattermost.web.cern.ch/acts/channels/code-review |
andiwand
left a comment
There was a problem hiding this comment.
couple of small comments and nitpicks but didn't go through completely yet
one major change I was not sure about yet is the telescope detector modifications. I thought the alignment of our detectors is already in place and general enough to support this. I think @asalzburger knows more about this
Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
thanks @goblirsc ! I think we only need one of them. could you extract these changes into a separate PR which just makes the |
Hi, sure - will prepare a follow up PR which ports the alignment functionality to the base |
|
…s-project#5256) Add a first demonstrator of MillePede alignment, using existing ACTS Kalman tracks.
--> #5369 |




Add a first demonstrator of MillePede alignment, using existing ACTS Kalman tracks.
--- END COMMIT MESSAGE ---
First step towards adding actual life to the MillePede ❤️ ACTS effort!
After making
Milleavailable as a plugin in we use it to write ACTS-Kalman tracks out into binary files that can be fit with the MillePede package.This path is simple (as we can re-use existing tracks), but computationally highly inefficient - we have to "undo" the track fit to bring the global covariance matrix of the Kalman tracks into the format expected by Millepede.
This should hence be seen as an initial proof of concept demonstrator.
For real-life usage, the
GeneralBrokenLinestrack refit (planned for ACTS-integration in the near future) will likely be a better choice for the fitter component in the alignment. But the final implementation should be sufficiently modular to work with any fitter nonetheless.In this MR, we add
Millebinaries, allowing to populate ACTSTrackAlignmentStates from Mille binariesAlignedTelescopeDetectorfor a simple showcase setupMillewriting and reading back into ACTS results in consistent alignment problemsThe alignment fit itself is performed outside ACTS using the MillePede package. Alternatively, it is possible to read the binaries back and solve using the ACTS tooling.