Arrange/data masking v3 ce#612
Conversation
Added new files for unmasking workflow functionality, including use cases for creating, retrieving, and managing unmasking workflows. Introduced data structures for unmasking workflows, SQL content, and related operations, ensuring compatibility with both DMS and non-DMS builds. This implementation lays the groundwork for enhanced data masking capabilities.
…ter organization Refactored the Confidence type and its associated constants by moving them from types_ee.go to a newly created types.go file. This change improves code organization and clarity, making it easier to manage and understand the confidence levels used in sensitive data detection.
数据导出集成查看原文工单功能 Added the DownloadOriginalDataExportWorkflow method to the DataExportWorkflowUsecase, enabling the download of unmasked data export workflows as a zip file. This includes validation checks for project UID, workflow status, and user permissions. Updated related service files to support this functionality, ensuring compatibility with both enterprise and community editions. Enhanced error handling and logging for better traceability.
|
没有在复审记录中找到这个MR => https://github.com/actiontech/dms-ee/issues/821 |
1 similar comment
|
没有在复审记录中找到这个MR => https://github.com/actiontech/dms-ee/issues/821 |
PR Reviewer Guide 🔍(Review updated until commit 162dc22)
|
PR Code Suggestions ✨Latest suggestions up to d6d303f
Previous suggestionsSuggestions up to commit d7a70a6
|
…iginal (CE) Owns the service struct wiring previously marked ee; pairs with biz/data_export EE implementation.
Updated the SQLResultMasker interface to include projectUID as a parameter for masking SQL results. Modified the CloudbeaverUsecase to pass projectUID during data masking operations. Introduced a new SQLResultMasker implementation for SQL workbench results, allowing for improved context and handling of masking operations. Refactored response writer to ensure consistent handling of response statuses and headers.
Added new endpoints for managing unmasking workflows, including creation, retrieval, approval, rejection, and cancellation. Introduced middleware for handling data masking and unmasking operations in SQL Workbench, ensuring proper permission checks and response handling. Enhanced the API structure to support these functionalities, improving overall data management capabilities.
…ing workflow functionality Updated the newExportMaskingTransfer method to include projectUID as a parameter, improving the masking transfer capabilities. Added markUnmaskingWorkflowUsage method to track unmasking workflow usage. Initialized unmaskingWorkflowUsecase in DMSService, enabling unmasking workflow management in the enterprise edition. Introduced new SQL workbench result masker implementations for both community and enterprise editions, ensuring proper handling based on build tags.
Owns the service struct type alignment previously marked ee; pairs with storage/model EE implementation.
Introduced the ListTableColumns method in the DMSService to handle requests for listing table columns. This method currently returns an error indicating unsupported data masking, laying the groundwork for future enhancements in data management capabilities.
Updated the locale files to include new messages related to unmasking workflows, enhancing user feedback for operations such as submission, approval, cancellation, and viewing details. This addition supports the recently implemented unmasking workflow features in the DMS service.
Introduced a new script to verify that the application can be built successfully under four different GO_BUILD_TAGS combinations: Community, Trial, Enterprise, and DMS Enterprise. This addition enhances the build process by ensuring compatibility across editions before submission.
Modified the ListMaskingRulesReq struct in masking.go to enhance documentation for the projectUid parameter. The comment now specifies that projectUid is injected via path for specific requests and is optional for global requests, improving clarity for API users.
…g_workflow optional Modified the ApproveUnmaskingWorkflowReq struct to change the approve_unmasking_workflow field from required to optional. Updated related documentation to reflect this change, clarifying that the field now carries an optional approve_reason. This adjustment improves API flexibility and aligns with user needs.
…sing Updated the AuditMiddleware function to enhance error handling by logging warnings instead of errors when parsing SQL requests fails or when SQL and datasource ID are empty. This change ensures that audit processing does not block user SQL execution. Additionally, modified the base64 decoding to use URL-safe encoding, improving compatibility with session IDs generated by the ODC server.
…emoving maskingTaskRepo Removed the maskingTaskRepo from the CloudbeaverUsecase and DataExportWorkflowUsecase, replacing its functionality with the new HasSensitiveDataMaskingTask method in the DBServiceUsecase. This change simplifies the usecases and enhances the handling of sensitive data masking tasks, improving overall code clarity and maintainability.
d7a70a6 to
d6d303f
Compare
|
没有在复审记录中找到这个MR => https://github.com/actiontech/dms-ee/issues/821 |
|
Persistent review updated to latest commit d6d303f |
|
没有在复审记录中找到这个MR => https://github.com/actiontech/dms-ee/issues/821 |
|
Persistent review updated to latest commit 162dc22 |
|
Failed to generate code suggestions for PR |
User description
关联的 issue
link https://github.com/actiontech/dms-ee/issues/821
描述你的变更
确认项(pr提交后操作)
Tip
请在指定复审人之前,确认并完成以下事项,完成后✅
not_compatibleneed_update_docDescription
增加查看原文/脱敏工单新接口
添加 unmasking workflow 数据结构与业务逻辑
调整 SQL 脱敏及数据导出流程支持项目 UID
添加 CE 版占位实现与构建校验脚本
Diagram Walkthrough
File Walkthrough
26 files
增加血缘分析与脱敏配置快照字段增加下载原文工单参数及接口文档新增列结构 API 定义调整 ProjectUid 查询参数说明新增完整 unmasking workflow API 定义添加内部接口 ListTableColumns 与 unmasking 接口新增 unmasking workflow 业务逻辑及数据结构CE 版 unmasking workflow 占位实现新增 Confidence 类型定义调整 SQLResultMasker 接口支持 ProjectUID 参数集成 unmasking workflow 与 masking 快照逻辑添加 DownloadOriginalDataExportWorkflow 占位方法新增查询及判断敏感数据脱敏任务的方法修改 CloudbeaverUsecase 初始化参数调用填充 unmasking workflow 汇总信息添加 CE 版下载原文工单接口占位添加 DBStructures CE 版占位实现更新 DMSService 初始化 unmasking workflow usecase添加 CE 版 SQLResultMasker 占位实现添加 CE 版 unmasking workflow 占位接口实现添加配置项支持 UnmaskingWorkflowUsecase添加 CE 版 data masking middleware 占位更新 SQLWorkbenchService 逻辑与 Base64 解码方式新增 SQLResultMasker 接口与参数定义新增多版本构建校验脚本添加 verify_edition_builds 构建目标3 files
新增 unmasking workflow 国际化消息增加 unmasking workflow 对应英文消息增加 unmasking workflow 对应中文消息