feat(sql_workbench): ODC workbench support for GoldenDB#610
Open
actiontech-bot wants to merge 3 commits into
Open
feat(sql_workbench): ODC workbench support for GoldenDB#610actiontech-bot wants to merge 3 commits into
actiontech-bot wants to merge 3 commits into
Conversation
… check #814 - Add GoldenDB -> MYSQL mapping in convertDBType(), consistent with TDSQL For InnoDB approach (MySQL protocol compatible) - Add DBTypeGoldenDB to SupportDBType() so GoldenDB datasources enter ODC sync and EE provision flows - Add unit test cases for both functions covering GoldenDB
…equests GoldenDB does not provide the information_schema database that ODC defaults to for MySQL-type connections, causing datasource status to be INACTIVE. Add DefaultSchema field to CreateDatasourceRequest, UpdateDatasourceRequest and datasourceBaseInfo so DMS can explicitly specify a default schema when syncing datasources to ODC. This change is paired with an ODC-side fix that stops hardcoding information_schema as the default schema for all MySQL-dialect types. Refs: actiontech/dms-ee#814
SQLE lacks plugins for GoldenDB, TBase, DB2, Hive, GaussDB etc. The AuditMiddleware previously blocked all /streamExecute requests when audit was disabled (error: "please enable SQL audit first") and failed when audit was enabled (SQLE cannot audit unsupported types). This made SQL execution completely unusable for GoldenDB data sources. Add isSQLAuditSupportedDBType() to check whether the data source's db_type has a corresponding SQLE audit plugin. For unsupported types the middleware now passes the request through to ODC without auditing. Supported types (MySQL, Oracle, OceanBase MySQL, TiDB, PostgreSQL, SQL Server, DM) retain their existing audit behavior unchanged. Fixes actiontech/dms-ee#814
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/actiontech/dms-ee/issues/814
Summary